diff mbox series

[v2] test/event_crypto_adapter: set cipher operation in transform

Message ID 20210118161940.6872-1-adwivedi@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series [v2] test/event_crypto_adapter: set cipher operation in transform |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing warning Testing issues

Commit Message

Ankur Dwivedi Jan. 18, 2021, 4:19 p.m. UTC 
  The symmetric session configure callback function in OCTEON TX2 crypto
PMD returns error if the cipher operation is not set to either encrypt
or decrypt. This patch sets the cipher operation for the null cipher
to encrypt.

Fixes: 74449375237f ("test/event_crypto_adapter: fix configuration")

Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
---
v2:
* Updated the commit message with details.

 app/test/test_event_crypto_adapter.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Gujjar, Abhinandan S Jan. 19, 2021, 7:13 a.m. UTC | #1 
Acked-by: abhinandan.gujjar@intel.com

Thanks & Regards
Abhinandan

> -----Original Message-----
> From: Ankur Dwivedi <adwivedi@marvell.com>
> Sent: Monday, January 18, 2021 9:50 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> akhil.goyal@nxp.com; anoobj@marvell.com; jerinj@marvell.com; Ankur
> Dwivedi <adwivedi@marvell.com>
> Subject: [PATCH v2] test/event_crypto_adapter: set cipher operation in
> transform
> 
> The symmetric session configure callback function in OCTEON TX2 crypto PMD
> returns error if the cipher operation is not set to either encrypt or decrypt. This
> patch sets the cipher operation for the null cipher to encrypt.
> 
> Fixes: 74449375237f ("test/event_crypto_adapter: fix configuration")
> 
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> ---
> v2:
> * Updated the commit message with details.
> 
>  app/test/test_event_crypto_adapter.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index a0169aa6cf..335211cd8c 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -183,6 +183,7 @@ test_op_forward_mode(uint8_t session_less)
>  	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
>  	cipher_xform.next = NULL;
>  	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> +	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> 
>  	op = rte_crypto_op_alloc(params.op_mpool,
>  			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
> @@ -382,6 +383,7 @@ test_op_new_mode(uint8_t session_less)
>  	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
>  	cipher_xform.next = NULL;
>  	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> +	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> 
>  	op = rte_crypto_op_alloc(params.op_mpool,
>  			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
> --
> 2.28.0
Jerin Jacob Jan. 26, 2021, 7:32 p.m. UTC | #2 
On Tue, Jan 19, 2021 at 12:43 PM Gujjar, Abhinandan S
<abhinandan.gujjar@intel.com> wrote:
>
> Acked-by: abhinandan.gujjar@intel.com


Applied to dpdk-next-eventdev/for-main. Thanks.



>
> Thanks & Regards
> Abhinandan
>
> > -----Original Message-----
> > From: Ankur Dwivedi <adwivedi@marvell.com>
> > Sent: Monday, January 18, 2021 9:50 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> > akhil.goyal@nxp.com; anoobj@marvell.com; jerinj@marvell.com; Ankur
> > Dwivedi <adwivedi@marvell.com>
> > Subject: [PATCH v2] test/event_crypto_adapter: set cipher operation in
> > transform
> >
> > The symmetric session configure callback function in OCTEON TX2 crypto PMD
> > returns error if the cipher operation is not set to either encrypt or decrypt. This
> > patch sets the cipher operation for the null cipher to encrypt.
> >
> > Fixes: 74449375237f ("test/event_crypto_adapter: fix configuration")
> >
> > Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> > ---
> > v2:
> > * Updated the commit message with details.
> >
> >  app/test/test_event_crypto_adapter.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/app/test/test_event_crypto_adapter.c
> > b/app/test/test_event_crypto_adapter.c
> > index a0169aa6cf..335211cd8c 100644
> > --- a/app/test/test_event_crypto_adapter.c
> > +++ b/app/test/test_event_crypto_adapter.c
> > @@ -183,6 +183,7 @@ test_op_forward_mode(uint8_t session_less)
> >       cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
> >       cipher_xform.next = NULL;
> >       cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> > +     cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> >
> >       op = rte_crypto_op_alloc(params.op_mpool,
> >                       RTE_CRYPTO_OP_TYPE_SYMMETRIC);
> > @@ -382,6 +383,7 @@ test_op_new_mode(uint8_t session_less)
> >       cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
> >       cipher_xform.next = NULL;
> >       cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> > +     cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> >
> >       op = rte_crypto_op_alloc(params.op_mpool,
> >                       RTE_CRYPTO_OP_TYPE_SYMMETRIC);
> > --
> > 2.28.0
>
diff mbox series

Patch

diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c
index a0169aa6cf..335211cd8c 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -183,6 +183,7 @@  test_op_forward_mode(uint8_t session_less)
 	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
 	cipher_xform.next = NULL;
 	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
+	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
 
 	op = rte_crypto_op_alloc(params.op_mpool,
 			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
@@ -382,6 +383,7 @@  test_op_new_mode(uint8_t session_less)
 	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
 	cipher_xform.next = NULL;
 	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
+	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
 
 	op = rte_crypto_op_alloc(params.op_mpool,
 			RTE_CRYPTO_OP_TYPE_SYMMETRIC);