net/mlx5: fix flow split combined with age action
Checks
Commit Message
Currently, for a flow containing an age action, if flow is split to
sub-flows, a new age action will be created for each sub-flow.
However only the action created for the last sub-flow will be queried
on flow query and cleared on flow removal.
This behavior is wrong, causing a leak of resources.
Need to create just one action per flow, and use it for all sub-flows.
This patch adds the required check to make sure an age action is
created just once per flow, and used by all sub-flows.
Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging")
Cc: stable@dpdk.org
Signed-off-by: Dekel Peled <dekelp@nvidia.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
Comments
From: Dekel Peled <dekelp@nvidia.com>
> Currently, for a flow containing an age action, if flow is split to sub-flows, a new
> age action will be created for each sub-flow.
> However only the action created for the last sub-flow will be queried on flow
> query and cleared on flow removal.
>
> This behavior is wrong, causing a leak of resources.
> Need to create just one action per flow, and use it for all sub-flows.
>
> This patch adds the required check to make sure an age action is created just
> once per flow, and used by all sub-flows.
>
> Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Sunday, January 17, 2021 11:41 AM
> To: Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow split combined with age
> action
>
> Currently, for a flow containing an age action, if flow is split to
> sub-flows, a new age action will be created for each sub-flow.
> However only the action created for the last sub-flow will be queried
> on flow query and cleared on flow removal.
>
> This behavior is wrong, causing a leak of resources.
> Need to create just one action per flow, and use it for all sub-flows.
>
> This patch adds the required check to make sure an age action is
> created just once per flow, and used by all sub-flows.
>
> Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@nvidia.com>
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
@@ -10077,14 +10077,22 @@ flow_dv_translate(struct rte_eth_dev *dev,
break;
case RTE_FLOW_ACTION_TYPE_AGE:
if (priv->sh->flow_hit_aso_en && attr->group) {
- flow->age = flow_dv_translate_create_aso_age
- (dev, action->conf, error);
- if (!flow->age)
- return rte_flow_error_set
+ /*
+ * Create one shared age action, to be used
+ * by all sub-flows.
+ */
+ if (!flow->age) {
+ flow->age =
+ flow_dv_translate_create_aso_age
+ (dev, action->conf,
+ error);
+ if (!flow->age)
+ return rte_flow_error_set
(error, rte_errno,
RTE_FLOW_ERROR_TYPE_ACTION,
NULL,
"can't create ASO age action");
+ }
dev_flow->dv.actions[actions_n++] =
(flow_aso_age_get_by_idx
(dev, flow->age))->dr_action;