test: add missing ticketlock test to fast tests
Checks
Commit Message
The ticketlock test is fast and should be run all the time.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/test/meson.build | 1 +
1 file changed, 1 insertion(+)
Comments
14/01/2021 17:58, Stephen Hemminger:
> The ticketlock test is fast and should be run all the time.
I think it was not added because it includes a perf test.
Cc'ing more people for comments.
On Sun, 17 Jan 2021 18:57:56 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:
> 14/01/2021 17:58, Stephen Hemminger:
> > The ticketlock test is fast and should be run all the time.
>
> I think it was not added because it includes a perf test.
> Cc'ing more people for comments.
>
>
Other lock code (rwlock is very similar and in the fast tests).
Stephen Hemminger <stephen@networkplumber.org> writes:
> On Sun, 17 Jan 2021 18:57:56 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
>
>> 14/01/2021 17:58, Stephen Hemminger:
>> > The ticketlock test is fast and should be run all the time.
>>
>> I think it was not added because it includes a perf test.
>> Cc'ing more people for comments.
>>
>>
>
> Other lock code (rwlock is very similar and in the fast tests).
I agree, it should be included. I did some digging and seems it wasn't
ever part of this set of lists, but could have been all along. As for
execution time, here's a run from the 0-day bot:
https://github.com/ovsrobot/dpdk/actions/runs/486047432
17m seems to be in the normal range.
Acked-by: Aaron Conole <aconole@redhat.com>
Thanks, Stephen!
18/01/2021 14:29, Aaron Conole:
> Stephen Hemminger <stephen@networkplumber.org> writes:
>
> > On Sun, 17 Jan 2021 18:57:56 +0100
> > Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> >> 14/01/2021 17:58, Stephen Hemminger:
> >> > The ticketlock test is fast and should be run all the time.
> >>
> >> I think it was not added because it includes a perf test.
> >> Cc'ing more people for comments.
> >>
> >>
> >
> > Other lock code (rwlock is very similar and in the fast tests).
>
> I agree, it should be included. I did some digging and seems it wasn't
> ever part of this set of lists, but could have been all along. As for
> execution time, here's a run from the 0-day bot:
>
> https://github.com/ovsrobot/dpdk/actions/runs/486047432
>
> 17m seems to be in the normal range.
>
> Acked-by: Aaron Conole <aconole@redhat.com>
>
> Thanks, Stephen!
Applied, thanks
@@ -245,6 +245,7 @@ fast_tests = [
['string_autotest', true],
['table_autotest', true],
['tailq_autotest', true],
+ ['ticketlock_autotest', true],
['timer_autotest', false],
['user_delay_us', true],
['version_autotest', true],