[v2] eal/windows: build rte_reciprocal functions

Message ID 1610406996-26992-2-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] eal/windows: build rte_reciprocal functions |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Tyler Retzlaff Jan. 11, 2021, 11:16 p.m. UTC
  From: Tyler Retzlaff <roretzla@microsoft.com>

build rte_reciprocal.c and export the following functions on windows
  * rte_reciprocal_value
  * rte_reciprocal_value_u64

Signed-off-by: Tyler Retzlaff <roretzla@microsoft.com>
---
 lib/librte_eal/common/meson.build  | 1 +
 lib/librte_eal/rte_eal_exports.def | 2 ++
 2 files changed, 3 insertions(+)
  

Comments

Dmitry Kozlyuk Jan. 11, 2021, 11:49 p.m. UTC | #1
On Mon, 11 Jan 2021 15:16:36 -0800, Tyler Retzlaff wrote:
> From: Tyler Retzlaff <roretzla@microsoft.com>
> 
> build rte_reciprocal.c and export the following functions on windows
>   * rte_reciprocal_value
>   * rte_reciprocal_value_u64
> 
> Signed-off-by: Tyler Retzlaff <roretzla@microsoft.com>
> ---

FYI, this is the place you could put description of changes in v2 for
single-item patch sets.

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
  
Thomas Monjalon Jan. 15, 2021, 1:56 p.m. UTC | #2
12/01/2021 00:49, Dmitry Kozlyuk:
> On Mon, 11 Jan 2021 15:16:36 -0800, Tyler Retzlaff wrote:
> > From: Tyler Retzlaff <roretzla@microsoft.com>
> > 
> > build rte_reciprocal.c and export the following functions on windows
> >   * rte_reciprocal_value
> >   * rte_reciprocal_value_u64
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@microsoft.com>
> > ---
> 
> FYI, this is the place you could put description of changes in v2 for
> single-item patch sets.
> 
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Applied, thanks
  

Patch

diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
index 39abf7a0a..9c6f18eb8 100644
--- a/lib/librte_eal/common/meson.build
+++ b/lib/librte_eal/common/meson.build
@@ -34,6 +34,7 @@  if is_windows
 		'rte_malloc.c',
 		'eal_common_timer.c',
 		'rte_service.c',
+		'rte_reciprocal.c',
 	)
 	subdir_done()
 endif
diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
index 4597eb8cd..99f64194d 100644
--- a/lib/librte_eal/rte_eal_exports.def
+++ b/lib/librte_eal/rte_eal_exports.def
@@ -128,6 +128,8 @@  EXPORTS
 	rte_memzone_walk
 	rte_openlog_stream
 	rte_realloc
+	rte_reciprocal_value
+	rte_reciprocal_value_u64
 	rte_rtm_supported
 	rte_service_attr_get
 	rte_service_attr_reset_all