| Message ID | 91bac54585547efe9cf7bafb7fd3994ddf13c070.1606225453.git.dekelp@nvidia.com |
|---|---|
| State | Accepted |
| Delegated to: | Raslan Darawsheh |
| Headers | show |
| Series |
|
| Related | show |
| Context | Check | Description |
|---|---|---|
| ci/travis-robot | success | Travis build: passed |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-testing | success | Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/checkpatch | success | coding style OK |
HI, > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled > Sent: Tuesday, November 24, 2020 3:46 PM > To: Slava Ovsiienko <viacheslavo@nvidia.com>; Shahaf Shuler > <shahafs@nvidia.com>; Matan Azrad <matan@nvidia.com> > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix shared age action validation > > Previous patch added support of shared age action. > This feature is supported on group 1 and higher, and validation was > added accordingly. > On FDB table the group 0 is skipped to improve performance. > As a result the mentioned validation is not relevant for transfer rules. > This patch adds the required check to ensure proper validation. > > Fixes: f9bc5274a6f9 ("net/mlx5: allow age modes combination") > Cc: stable@dpdk.org > > Signed-off-by: Dekel Peled <dekelp@nvidia.com> > Acked-by: Matan Azrad <matan@nvidia.com> Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 253f598310..fd83afe140 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -5955,7 +5955,7 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr, rw_act_num += MLX5_ACT_NUM_SET_TAG; break; case MLX5_RTE_FLOW_ACTION_TYPE_AGE: - if (!attr->group) + if (!attr->transfer && !attr->group) return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
Previous patch added support of shared age action. This feature is supported on group 1 and higher, and validation was added accordingly. On FDB table the group 0 is skipped to improve performance. As a result the mentioned validation is not relevant for transfer rules. This patch adds the required check to ensure proper validation. Fixes: f9bc5274a6f9 ("net/mlx5: allow age modes combination") Cc: stable@dpdk.org Signed-off-by: Dekel Peled <dekelp@nvidia.com> Acked-by: Matan Azrad <matan@nvidia.com> --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)