| Message ID | 20201123070523.21661-1-murphyx.yang@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Qi Zhang |
| Headers | show |
| Series |
|
| Related | show |
| Context | Check | Description |
|---|---|---|
| ci/travis-robot | success | Travis build: passed |
| ci/iol-testing | warning | Testing issues |
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/checkpatch | success | coding style OK |
Tested-by: Xie,WeiX < weix.xie@intel.com> Regards, Xie Wei > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Murphy Yang > Sent: Monday, November 23, 2020 3:05 PM > To: dev@dpdk.org > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z > <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Yang, > MurphyX <murphyx.yang@intel.com> > Subject: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum > error > > If enable hardware outer UDP TX offload checksum, it doesn't take effect > when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum. > > In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT' > equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware can > calculate the outer tunneling UDP checksum. > > Fixes: bd70c451532c ("net/ice: support Tx checksum offload for tunnel") > > Signed-off-by: Murphy Yang <murphyx.yang@intel.com> > --- > drivers/net/ice/ice_rxtx.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index > 5fbd68eafc..9769e216bf 100644 > --- a/drivers/net/ice/ice_rxtx.c > +++ b/drivers/net/ice/ice_rxtx.c > @@ -2319,8 +2319,11 @@ ice_parse_tunneling_params(uint64_t ol_flags, > *cd_tunneling |= (tx_offload.l2_len >> 1) << > ICE_TXD_CTX_QW0_NATLEN_S; > > - if ((ol_flags & PKT_TX_OUTER_UDP_CKSUM) && > - (ol_flags & PKT_TX_OUTER_IP_CKSUM) && > + /** > + * Calculate the tunneling UDP checksum. > + * Shall be set only if L4TUNT = 01b and EIPT is not zero > + */ > + if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) && > (*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING)) > *cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M; } > -- > 2.17.1
> -----Original Message----- > From: Xie, WeiX <weix.xie@intel.com> > Sent: Monday, November 23, 2020 4:31 PM > To: Yang, MurphyX <murphyx.yang@intel.com>; dev@dpdk.org > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; > Yang, SteveX <stevex.yang@intel.com>; Yang, MurphyX > <murphyx.yang@intel.com> > Subject: RE: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum > error > > Tested-by: Xie,WeiX < weix.xie@intel.com> > > Regards, > Xie Wei > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Murphy Yang > > Sent: Monday, November 23, 2020 3:05 PM > > To: dev@dpdk.org > > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z > > <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Yang, > > MurphyX <murphyx.yang@intel.com> > > Subject: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum > > error > > > > If enable hardware outer UDP TX offload checksum, it doesn't take > > effect when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum. > > > > In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT' > > equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the > > hardware can calculate the outer tunneling UDP checksum. > > > > Fixes: bd70c451532c ("net/ice: support Tx checksum offload for > > tunnel") > > > > Signed-off-by: Murphy Yang <murphyx.yang@intel.com> Acked-by: Qi Zhang <qi.z.zhang@intel.com> Applied to dpdk-next-net-intel. Thanks Qi
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index 5fbd68eafc..9769e216bf 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b/drivers/net/ice/ice_rxtx.c @@ -2319,8 +2319,11 @@ ice_parse_tunneling_params(uint64_t ol_flags, *cd_tunneling |= (tx_offload.l2_len >> 1) << ICE_TXD_CTX_QW0_NATLEN_S; - if ((ol_flags & PKT_TX_OUTER_UDP_CKSUM) && - (ol_flags & PKT_TX_OUTER_IP_CKSUM) && + /** + * Calculate the tunneling UDP checksum. + * Shall be set only if L4TUNT = 01b and EIPT is not zero + */ + if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) && (*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING)) *cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M; }
If enable hardware outer UDP TX offload checksum, it doesn't take effect when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum. In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT' equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware can calculate the outer tunneling UDP checksum. Fixes: bd70c451532c ("net/ice: support Tx checksum offload for tunnel") Signed-off-by: Murphy Yang <murphyx.yang@intel.com> --- drivers/net/ice/ice_rxtx.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)