From patchwork Thu Nov 19 11:58:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 84373 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E92ADA04DD; Thu, 19 Nov 2020 13:00:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 99747C8F2; Thu, 19 Nov 2020 12:59:17 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id F2A2D23D; Thu, 19 Nov 2020 12:59:12 +0100 (CET) IronPort-SDR: aOXNT7GrI2v3NF0HFfJl3mUes50Jb0EgkQaOp0pX4iqQhCKUiXIp6vIedd0D2KGh983+SD+3+T qEEow15pvA6w== X-IronPort-AV: E=McAfee;i="6000,8403,9809"; a="170494394" X-IronPort-AV: E=Sophos;i="5.77,490,1596524400"; d="scan'208";a="170494394" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2020 03:59:12 -0800 IronPort-SDR: hEC389ZuUbgCZ8VnFDSYGysXGiJ3G+THcqFF37l4JEom53M3qnjaxlx0fsKAK0+wRM4xuRjr0r WtVoV+8Q5XRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,490,1596524400"; d="scan'208";a="341665163" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga002.jf.intel.com with ESMTP; 19 Nov 2020 03:59:10 -0800 From: Ferruh Yigit To: dev@dpdk.org, Maryam Tahhan , Reshma Pattan , John McNamara , Vipin Varghese Cc: Ferruh Yigit , stable@dpdk.org, David Marchand Date: Thu, 19 Nov 2020 11:58:53 +0000 Message-Id: <20201119115900.4095566-4-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201119115900.4095566-1-ferruh.yigit@intel.com> References: <20200824094021.2323605-1-ferruh.yigit@intel.com> <20201119115900.4095566-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [v21.02 v3 03/10] app/procinfo: remove suspicious sizeof X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The intention with the "sizeof(0)" usage is not clear, but the 'stats' already 'memset' by 'rte_cryptodev_stats_get()' API, removing 'memset' in application. Fixes: fe773600fe3e ("app/procinfo: add --show-crypto") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand --- app/proc-info/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 8ee30ddb71..106b44d6fb 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -1207,7 +1207,6 @@ show_crypto(void) display_crypto_feature_info(dev_info.feature_flags); - memset(&stats, 0, sizeof(0)); if (rte_cryptodev_stats_get(i, &stats) == 0) { printf("\t -- stats\n"); printf("\t\t + enqueue count (%"PRIu64")"