| Message ID | 20201119115900.4095566-2-ferruh.yigit@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | David Marchand |
| Headers | show |
| Series |
|
| Related | show |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
On Thu, Nov 19, 2020 at 12:59 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > > '_filters' is compared twice, second one will be always false, removing > it using the message more relevant to the '_filters'. > > Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> Reviewed-by: David Marchand <david.marchand@redhat.com>
diff --git a/app/proc-info/main.c b/app/proc-info/main.c index d743209f0d..35e5b596eb 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -420,11 +420,9 @@ static void collectd_resolve_cnt_type(char *cnt_type, size_t cnt_type_len, } else if ((type_end != NULL) && (strncmp(cnt_name, "flow_", strlen("flow_"))) == 0) { if (strncmp(type_end, "_filters", strlen("_filters")) == 0) - strlcpy(cnt_type, "operations", cnt_type_len); + strlcpy(cnt_type, "filter_result", cnt_type_len); else if (strncmp(type_end, "_errors", strlen("_errors")) == 0) strlcpy(cnt_type, "errors", cnt_type_len); - else if (strncmp(type_end, "_filters", strlen("_filters")) == 0) - strlcpy(cnt_type, "filter_result", cnt_type_len); } else if ((type_end != NULL) && (strncmp(cnt_name, "mac_", strlen("mac_"))) == 0) { if (strncmp(type_end, "_errors", strlen("_errors")) == 0)
'_filters' is compared twice, second one will be always false, removing it using the message more relevant to the '_filters'. Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> --- app/proc-info/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)