net/mlx5: fix RSS queue types validation
diff mbox series

Message ID 8e069ae0fd8b042051a81ee1227ac50e7d841200.1605691382.git.dekelp@nvidia.com
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers show
Series
  • net/mlx5: fix RSS queue types validation
Related show

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/Intel-compilation success Compilation OK
ci/iol-testing warning Testing issues
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Dekel Peled Nov. 18, 2020, 9:24 a.m. UTC
Recent patch fixed the RSS action validation, making sure hairpin queues
and standard queues are not used together in the same RSS action.
The variable used for comparison was declared and initialized within the
check loop, making the queue type comparison wrong.

This patch moves the variable declaration to the start of the function,
outside of the check loop.

Fixes: cb8a079aee5d ("net/mlx5: fix validate RSS queues types")

Signed-off-by: Dekel Peled <dekelp@nvidia.com>
Acked-by: Ori Kam <orika@nvidia.com>
Acked-by: Jack Min <jackmin@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Raslan Darawsheh Nov. 18, 2020, 3:34 p.m. UTC | #1
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Wednesday, November 18, 2020 11:24 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS queue types validation
> 
> Recent patch fixed the RSS action validation, making sure hairpin queues
> and standard queues are not used together in the same RSS action.
> The variable used for comparison was declared and initialized within the
> check loop, making the queue type comparison wrong.
> 
> This patch moves the variable declaration to the start of the function,
> outside of the check loop.
> 
> Fixes: cb8a079aee5d ("net/mlx5: fix validate RSS queues types")
> 
> Signed-off-by: Dekel Peled <dekelp@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
> Acked-by: Jack Min <jackmin@nvidia.com>
> ---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
Ferruh Yigit Nov. 20, 2020, 11:24 a.m. UTC | #2
On 11/18/2020 3:34 PM, Raslan Darawsheh wrote:
> Hi,
> 
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
>> Sent: Wednesday, November 18, 2020 11:24 AM
>> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Shahaf Shuler
>> <shahafs@nvidia.com>; Matan Azrad <matan@nvidia.com>
>> Cc: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] net/mlx5: fix RSS queue types validation
>>
>> Recent patch fixed the RSS action validation, making sure hairpin queues
>> and standard queues are not used together in the same RSS action.
>> The variable used for comparison was declared and initialized within the
>> check loop, making the queue type comparison wrong.
>>
>> This patch moves the variable declaration to the start of the function,
>> outside of the check loop.
>>
>> Fixes: cb8a079aee5d ("net/mlx5: fix validate RSS queues types")
>>
>> Signed-off-by: Dekel Peled <dekelp@nvidia.com>
>> Acked-by: Ori Kam <orika@nvidia.com>
>> Acked-by: Jack Min <jackmin@nvidia.com>
>> ---
> 
> Patch applied to next-net-mlx,
> 

Squashed into relevant commit in next-net, thanks.

Patch
diff mbox series

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 33dbbd9eef..236610c8fc 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1411,6 +1411,7 @@  mlx5_validate_action_rss(struct rte_eth_dev *dev,
 {
 	struct mlx5_priv *priv = dev->data->dev_private;
 	const struct rte_flow_action_rss *rss = action->conf;
+	enum mlx5_rxq_type rxq_type = MLX5_RXQ_TYPE_UNDEFINED;
 	unsigned int i;
 
 	if (rss->func != RTE_ETH_HASH_FUNCTION_DEFAULT &&
@@ -1476,7 +1477,6 @@  mlx5_validate_action_rss(struct rte_eth_dev *dev,
 					  RTE_FLOW_ERROR_TYPE_ACTION_CONF,
 					  NULL, "No queues configured");
 	for (i = 0; i != rss->queue_num; ++i) {
-		enum mlx5_rxq_type rxq_type = MLX5_RXQ_TYPE_UNDEFINED;
 		struct mlx5_rxq_ctrl *rxq_ctrl;
 
 		if (rss->queue[i] >= priv->rxqs_n)