diff mbox series

net/mlx5: fix assertion check warnings

Message ID 1605610883-6619-1-git-send-email-xuemingl@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series net/mlx5: fix assertion check warnings |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing warning Testing issues
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Xueming Li Nov. 17, 2020, 11:01 a.m. UTC 
  Fix assertion check warnings.

Fixes: 8bb81f2649b1 ("net/mlx5: use thread specific flow workspace")

Cc: stable@dpdk.org
Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Reviewed-by: Slava Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Raslan Darawsheh Nov. 17, 2020, 8:53 p.m. UTC | #1 
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xueming Li
> Sent: Tuesday, November 17, 2020 1:01 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; Xueming(Steven) Li <xuemingl@nvidia.com>; Asaf Penso
> <asafp@nvidia.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix assertion check warnings
> 
> Fix assertion check warnings.
> 
> Fixes: 8bb81f2649b1 ("net/mlx5: use thread specific flow workspace")
> 
> Cc: stable@dpdk.org
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> Reviewed-by: Slava Ovsiienko <viacheslavo@nvidia.com>
> ---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
Thomas Monjalon Nov. 21, 2020, 11:36 a.m. UTC | #2 
> > Fix assertion check warnings.
> > 
> > Fixes: 8bb81f2649b1 ("net/mlx5: use thread specific flow workspace")
> > 
> > Cc: stable@dpdk.org
> > Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> > Reviewed-by: Slava Ovsiienko <viacheslavo@nvidia.com>
> 
> Patch applied to next-net-mlx,

I know this patch is minor, but we should not write, review and apply
a fix which does not explain the issue, not even referencing the warning.
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
index f64384217f..afddcfc12c 100644
--- a/drivers/net/mlx5/mlx5_flow.h
+++ b/drivers/net/mlx5/mlx5_flow.h
@@ -1108,7 +1108,7 @@  struct mlx5_flow_workspace {
 	struct mlx5_flow flows[MLX5_NUM_MAX_DEV_FLOWS];
 	struct mlx5_flow_rss_desc rss_desc;
 	uint32_t rssq_num; /* Allocated queue num in rss_desc. */
-	int flow_idx; /* Intermediate device flow index. */
+	uint32_t flow_idx; /* Intermediate device flow index. */
 };
 
 struct mlx5_flow_split_info {