[06/10] examples/ntb: fix clean target

Message ID 20201110151219.4893-7-david.marchand@redhat.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Examples compilation fixes |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

David Marchand Nov. 10, 2020, 3:12 p.m. UTC
  When introducing this example, the cleanup from commit 7e9562a107f1
("examples: fix make clean when using pkg-config") was missed.

Fixes: c5eebf85badc ("examples/ntb: add example for NTB")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 examples/ntb/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Li, Xiaoyun Nov. 12, 2020, 1:30 a.m. UTC | #1
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, November 10, 2020 23:12
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; Richardson, Bruce <bruce.richardson@intel.com>;
> stable@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Xiaolong Ye <xiaolong.ye@intel.com>
> Subject: [PATCH 06/10] examples/ntb: fix clean target
> 
> When introducing this example, the cleanup from commit 7e9562a107f1
> ("examples: fix make clean when using pkg-config") was missed.
> 
> Fixes: c5eebf85badc ("examples/ntb: add example for NTB")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  examples/ntb/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/ntb/Makefile b/examples/ntb/Makefile index
> 4675570fd2..d35dabc471 100644
> --- a/examples/ntb/Makefile
> +++ b/examples/ntb/Makefile
> @@ -42,4 +42,4 @@ build:
>  .PHONY: clean
>  clean:
>  	rm -f build/$(APP) build/$(APP)-static build/$(APP)-shared
> -	rmdir --ignore-fail-on-non-empty build
> +	test -d build && rmdir -p build || true
> --
> 2.23.0

Thanks for the catch.

Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
  

Patch

diff --git a/examples/ntb/Makefile b/examples/ntb/Makefile
index 4675570fd2..d35dabc471 100644
--- a/examples/ntb/Makefile
+++ b/examples/ntb/Makefile
@@ -42,4 +42,4 @@  build:
 .PHONY: clean
 clean:
 	rm -f build/$(APP) build/$(APP)-static build/$(APP)-shared
-	rmdir --ignore-fail-on-non-empty build
+	test -d build && rmdir -p build || true