From patchwork Fri Oct 30 17:36:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Power, Ciara" X-Patchwork-Id: 82973 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98C27A04E6; Fri, 30 Oct 2020 18:36:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 759F32C27; Fri, 30 Oct 2020 18:36:48 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0EDE42C1A for ; Fri, 30 Oct 2020 18:36:45 +0100 (CET) IronPort-SDR: XDdIrb2OhDKgpHfvcVQN2rdNndAPAuj93wAhNYJKh2t/hW1Zk3WQdDKh3qTzOYczMcmHzFMMVc I9zxmBCoIJFw== X-IronPort-AV: E=McAfee;i="6000,8403,9790"; a="253348357" X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="253348357" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 10:36:45 -0700 IronPort-SDR: h2F6ArHBCXP4dmBiUHjjZHHF0lNrtsw1n3h1qL1wfpYALvju9cSx4UGnntVUutwtPk58D9SeGa QwG0gJyAgUUw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="527183608" Received: from silpixa00400355.ir.intel.com (HELO silpixa00400355.ger.corp.intel.com) ([10.237.223.148]) by fmsmga005.fm.intel.com with ESMTP; 30 Oct 2020 10:36:43 -0700 From: Ciara Power To: dev@dpdk.org Cc: david.marchand@redhat.com, Ciara Power , roy.fan.zhang@intel.com, Marko Kovacevic Date: Fri, 30 Oct 2020 17:36:40 +0000 Message-Id: <20201030173641.374525-1-ciara.power@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201028155327.104488-1-ciara.power@intel.com> References: <20201028155327.104488-1-ciara.power@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2] examples/fips_validation: fix resource leak on failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The wb_data variable went out of scope on failure in the get_writeback_data function. This is now freed before returning -1. Coverity issue: 363453 Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list") Cc: roy.fan.zhang@intel.com Signed-off-by: Ciara Power Reviewed-by: David Marchand --- v2: Fixed incorrect pointer used in free. --- examples/fips_validation/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index 07532c9562..b37eb41c0d 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c @@ -1128,6 +1128,7 @@ get_writeback_data(struct fips_val *val) if (data_len) { RTE_LOG(ERR, USER1, "Error -1: write back data\n"); + free(wb_data); return -1; }