[v2] examples/fips_validation: fix resource leak on failure
Checks
Commit Message
The wb_data variable went out of scope on failure in the
get_writeback_data function. This is now freed before returning -1.
Coverity issue: 363453
Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list")
Cc: roy.fan.zhang@intel.com
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
v2: Fixed incorrect pointer used in free.
---
examples/fips_validation/main.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Fri, Oct 30, 2020 at 6:36 PM Ciara Power <ciara.power@intel.com> wrote:
>
> The wb_data variable went out of scope on failure in the
> get_writeback_data function. This is now freed before returning -1.
>
> Coverity issue: 363453
> Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list")
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
@@ -1128,6 +1128,7 @@ get_writeback_data(struct fips_val *val)
if (data_len) {
RTE_LOG(ERR, USER1, "Error -1: write back data\n");
+ free(wb_data);
return -1;
}