[v2] test: fix GMAC SGL test
diff mbox series

Message ID 20201029144631.989873-1-roy.fan.zhang@intel.com
State Accepted
Delegated to: akhil goyal
Headers show
Series
  • [v2] test: fix GMAC SGL test
Related show

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Zhang, Roy Fan Oct. 29, 2020, 2:46 p.m. UTC
This patch fixes the GMAC SGL test that fails to bypass
unsupported PMDs.

Fixes: dcdd01691f39 ("test/crypto: add GMAC SGL")
Cc: pablo.de.lara.guarch@intel.com

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
v2:
- fix typo
 app/test/test_cryptodev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jiang, YuX Oct. 30, 2020, 2:16 a.m. UTC | #1
Tested-by: JiangYuX <yux.jiang@intel.com>

    Best Regards
    Jiang yu


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> Sent: Thursday, October 29, 2020 10:47 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [dpdk-dev v2] test: fix GMAC SGL test
> 
> This patch fixes the GMAC SGL test that fails to bypass unsupported PMDs.
> 
> Fixes: dcdd01691f39 ("test/crypto: add GMAC SGL")
> Cc: pablo.de.lara.guarch@intel.com
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> v2:
> - fix typo
>  app/test/test_cryptodev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index
> 0fed124d3..130719d67 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -11069,8 +11069,8 @@ test_AES_GMAC_authentication_SGL(const
> struct gmac_test_data *tdata,
>  	rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
>  	feature_flags = dev_info.feature_flags;
> 
> -	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) &&
> -			(!(feature_flags &
> RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) &&
> +	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) ||
> +			(!(feature_flags &
> RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) ||
>  			(!(feature_flags &
> RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT)))
>  		return -ENOTSUP;
> 
> --
> 2.26.2
Pablo de Lara Nov. 3, 2020, 12:54 p.m. UTC | #2
> -----Original Message-----
> From: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Sent: Thursday, October 29, 2020 2:47 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; De Lara
> Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev v2] test: fix GMAC SGL test
> 
> This patch fixes the GMAC SGL test that fails to bypass unsupported PMDs.
> 
> Fixes: dcdd01691f39 ("test/crypto: add GMAC SGL")
> Cc: pablo.de.lara.guarch@intel.com
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>

Commit message can be changed to "test/crypto: fix GMAC SGL", but I think it can be changed when applying the patch.

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Akhil Goyal Nov. 4, 2020, 7:07 a.m. UTC | #3
> > Subject: [dpdk-dev v2] test: fix GMAC SGL test
> >
> > This patch fixes the GMAC SGL test that fails to bypass unsupported PMDs.
> >
> > Fixes: dcdd01691f39 ("test/crypto: add GMAC SGL")
> > Cc: pablo.de.lara.guarch@intel.com
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> 
> Commit message can be changed to "test/crypto: fix GMAC SGL", but I think it
> can be changed when applying the patch.
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto

Thanks.

Patch
diff mbox series

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 0fed124d3..130719d67 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -11069,8 +11069,8 @@  test_AES_GMAC_authentication_SGL(const struct gmac_test_data *tdata,
 	rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
 	feature_flags = dev_info.feature_flags;
 
-	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) &&
-			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) &&
+	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) ||
+			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) ||
 			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT)))
 		return -ENOTSUP;