Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
Commit Message
Ophir Munk
Oct. 27, 2020, 11:23 p.m. UTC
Exclude call to rte_intr_callback_register under Windows using
definition RTE_EXEC_ENV_WINDOWS.
Signed-off-by: Ophir Munk <ophirmu@nvidia.com>
---
drivers/net/mlx5/mlx5_txpp.c | 2 ++
1 file changed, 2 insertions(+)
Comments
28/10/2020 00:23, Ophir Munk: > Exclude call to rte_intr_callback_register under Windows using > definition RTE_EXEC_ENV_WINDOWS. Rather than describing what is done, it is more interesting to know why. Note: this is a general comment which may apply for other commits.
diff --git a/drivers/net/mlx5/mlx5_txpp.c b/drivers/net/mlx5/mlx5_txpp.c index c22ddc9..4405054 100644 --- a/drivers/net/mlx5/mlx5_txpp.c +++ b/drivers/net/mlx5/mlx5_txpp.c @@ -896,12 +896,14 @@ mlx5_txpp_start_service(struct mlx5_dev_ctx_shared *sh) fd = mlx5_os_get_devx_channel_fd(sh->txpp.echan); sh->txpp.intr_handle.fd = fd; sh->txpp.intr_handle.type = RTE_INTR_HANDLE_EXT; +#ifndef RTE_EXEC_ENV_WINDOWS if (rte_intr_callback_register(&sh->txpp.intr_handle, mlx5_txpp_interrupt_handler, sh)) { sh->txpp.intr_handle.fd = 0; DRV_LOG(ERR, "Failed to register CQE interrupt %d.", rte_errno); return -rte_errno; } +#endif /* Subscribe CQ event to the event channel controlled by the driver. */ ret = mlx5_os_devx_subscribe_devx_event(sh->txpp.echan, sh->txpp.rearm_queue.cq->obj,