[v1,37/72] mlx5/windows: add mlx5_os header file under net

Message ID 20201027232335.31427-38-ophirmu@nvidia.com (mailing list archive)
State Superseded, archived
Delegated to: Raslan Darawsheh
Headers
Series mlx5 Windows support - part #5 |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Ophir Munk Oct. 27, 2020, 11:23 p.m. UTC
  File drivers/net/mlx5/windows/mlx5_os.h is added. It includes specific
Windows definitions such as PCI driver flags link state changes
interrupts, link removal interrupts.

Signed-off-by: Ophir Munk <ophirmu@nvidia.com>
---
 drivers/net/mlx5/windows/mlx5_os.h | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 drivers/net/mlx5/windows/mlx5_os.h
  

Comments

Thomas Monjalon Oct. 28, 2020, 7:18 a.m. UTC | #1
28/10/2020 00:23, Ophir Munk:
> File drivers/net/mlx5/windows/mlx5_os.h is added. It includes specific
> Windows definitions such as PCI driver flags link state changes
> interrupts, link removal interrupts.

The description does not match the content below.

> Signed-off-by: Ophir Munk <ophirmu@nvidia.com>
> ---
> --- /dev/null
> +++ b/drivers/net/mlx5/windows/mlx5_os.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright 2020 Mellanox Technologies, Ltd
> + */
> +
> +#ifndef RTE_PMD_MLX5_OS_H_
> +#define RTE_PMD_MLX5_OS_H_
> +/* sysfs equivalent under Windows */
> +enum {
> +	SYSFS_NAME_MAX = 64,
> +	SYSFS_PATH_MAX = 256
> +};
> +enum {
> +	DEV_SYSFS_NAME_MAX = SYSFS_NAME_MAX + 1,
> +	DEV_SYSFS_PATH_MAX = SYSFS_PATH_MAX + 1
> +};

There is no sysfs on Windows, so why do you need these definitions?

> +
> +#define PCI_DRV_FLAGS 0
> +
> +#endif /* RTE_PMD_MLX5_OS_H_ */
  

Patch

diff --git a/drivers/net/mlx5/windows/mlx5_os.h b/drivers/net/mlx5/windows/mlx5_os.h
new file mode 100644
index 0000000..bb1aa27
--- /dev/null
+++ b/drivers/net/mlx5/windows/mlx5_os.h
@@ -0,0 +1,19 @@ 
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2020 Mellanox Technologies, Ltd
+ */
+
+#ifndef RTE_PMD_MLX5_OS_H_
+#define RTE_PMD_MLX5_OS_H_
+/* sysfs equivalent under Windows */
+enum {
+	SYSFS_NAME_MAX = 64,
+	SYSFS_PATH_MAX = 256
+};
+enum {
+	DEV_SYSFS_NAME_MAX = SYSFS_NAME_MAX + 1,
+	DEV_SYSFS_PATH_MAX = SYSFS_PATH_MAX + 1
+};
+
+#define PCI_DRV_FLAGS 0
+
+#endif /* RTE_PMD_MLX5_OS_H_ */