diff mbox series

examples: fix linking against specific drivers

Message ID 20201027171953.887251-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series examples: fix linking against specific drivers |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Bruce Richardson Oct. 27, 2020, 5:19 p.m. UTC 
  Some example apps rely on driver-specific functionality and link explicitly
against those drivers. These apps need their makefiles updated to take
account of the renaming of the driver libs.

Fixes: a20b2c01a7a1 ("build: standardize component names and defines")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 examples/bond/Makefile             | 2 +-
 examples/ethtool/lib/Makefile      | 2 +-
 examples/vm_power_manager/Makefile | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

David Marchand Oct. 30, 2020, 1:35 p.m. UTC | #1 
On Tue, Oct 27, 2020 at 6:20 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> Some example apps rely on driver-specific functionality and link explicitly
> against those drivers. These apps need their makefiles updated to take
> account of the renaming of the driver libs.
>
> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied, thanks Bruce.


I think the documentation would also need some fixes as I can see a
lot of references to librte_pmd_.
Bruce Richardson Nov. 2, 2020, 5:47 p.m. UTC | #2 
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Friday, October 30, 2020 1:36 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>
> Cc: dev <dev@dpdk.org>; Thomas Monjalon <thomas@monjalon.net>
> Subject: Re: [dpdk-dev] [PATCH] examples: fix linking against specific
> drivers
> 
> On Tue, Oct 27, 2020 at 6:20 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > Some example apps rely on driver-specific functionality and link
> explicitly
> > against those drivers. These apps need their makefiles updated to take
> > account of the renaming of the driver libs.
> >
> > Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> 
> Applied, thanks Bruce.
> 
> 
> I think the documentation would also need some fixes as I can see a
> lot of references to librte_pmd_.
> 

First draft patchset sent, based off grepping the docs for "librte_pmd_".

http://patches.dpdk.org/project/dpdk/list/?series=13578

/Bruce
diff mbox series

Patch

diff --git a/examples/bond/Makefile b/examples/bond/Makefile
index 4e560f574c..8700b589fb 100644
--- a/examples/bond/Makefile
+++ b/examples/bond/Makefile
@@ -19,7 +19,7 @@  shared: build/$(APP)-shared
 static: build/$(APP)-static
 	ln -sf $(APP)-static build/$(APP)
 
-LDFLAGS += -lrte_pmd_bond
+LDFLAGS += -lrte_net_bond
 
 PKGCONF ?= pkg-config
 
diff --git a/examples/ethtool/lib/Makefile b/examples/ethtool/lib/Makefile
index 3bc2b9d8ba..b4af9b0c91 100644
--- a/examples/ethtool/lib/Makefile
+++ b/examples/ethtool/lib/Makefile
@@ -27,7 +27,7 @@  LDFLAGS += -Wl,--no-undefined $(LDFLAGS_SHARED)
 
 # check for ixgbe by grepping pre-processor output
 ifneq ($(shell $(CC) $(CFLAGS) -dM -E - < /dev/null | grep IXGBE),)
-LDFLAGS += -lrte_pmd_ixgbe
+LDFLAGS += -lrte_net_ixgbe
 endif
 
 .PHONY: all clean static shared
diff --git a/examples/vm_power_manager/Makefile b/examples/vm_power_manager/Makefile
index 87b9744d8c..027d17c7ef 100644
--- a/examples/vm_power_manager/Makefile
+++ b/examples/vm_power_manager/Makefile
@@ -44,7 +44,7 @@  CFLAGS += -DUSE_JANSSON
 endif
 
 # for shared library builds, we need to explicitly link these PMDs
-LDFLAGS_SHARED += -lrte_pmd_ixgbe -lrte_pmd_i40e -lrte_pmd_bnxt
+LDFLAGS_SHARED += -lrte_net_ixgbe -lrte_net_i40e -lrte_net_bnxt
 
 build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build
 	$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)