diff mbox series

[v1] app/regex: configure qp according to device capabilities

Message ID 20201020091008.25537-1-guyk@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] app/regex: configure qp according to device capabilities |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Performance-Testing fail build patch failure
ci/travis-robot warning Travis build: failed
ci/Intel-compilation fail Compilation issues

Commit Message

Guy Kaneti Oct. 20, 2020, 9:10 a.m. UTC 
  From: Guy Kaneti <guyk@marvell.com>

configure qp with OOS according to device capabilities
returned from rte_regexdev_info_get.

Signed-off-by: Guy Kaneti <guyk@marvell.com>
---
 app/test-regex/main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Ori Kam Oct. 20, 2020, 9:14 a.m. UTC | #1 
Hi Guy,

> -----Original Message-----
> From: guyk@marvell.com <guyk@marvell.com>
> Sent: Tuesday, October 20, 2020 12:10 PM
> Subject: [PATCH v1] app/regex: configure qp according to device capabilities
> 
> From: Guy Kaneti <guyk@marvell.com>
> 
> configure qp with OOS according to device capabilities
> returned from rte_regexdev_info_get.
> 
> Signed-off-by: Guy Kaneti <guyk@marvell.com>
> ---
>  app/test-regex/main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test-regex/main.c b/app/test-regex/main.c
> index e6080b44b..3deaf3c80 100644
> --- a/app/test-regex/main.c
> +++ b/app/test-regex/main.c
> @@ -173,7 +173,7 @@ init_port(struct rte_mempool **mbuf_mp, uint32_t
> nb_jobs,
>  	};
>  	struct rte_regexdev_qp_conf qp_conf = {
>  		.nb_desc = 1024,
> -		.qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
> +		.qp_conf_flags = 0,
>  	};
>  	int res = 0;
> 
> @@ -218,6 +218,8 @@ init_port(struct rte_mempool **mbuf_mp, uint32_t
> nb_jobs,
>  			printf("Error, can't configure device %d.\n", id);
>  			goto error;
>  		}
> +		if (info.regexdev_capa &
> RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F)
> +			qp_conf.qp_conf_flags |=
> RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
>  		res = rte_regexdev_queue_pair_setup(id, 0, &qp_conf);
>  		if (res < 0) {
>  			printf("Error, can't setup queue pair for device %d.\n",
> --
> 2.28.0

Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori
Ophir Munk Oct. 22, 2020, 10:53 a.m. UTC | #2 
Hi Guy,
I could not find RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F defined in latest dpdk/main. As a result my compilation is broken.
Can you please assist?

Regards,
Ophir

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ori Kam
> Sent: Tuesday, October 20, 2020 12:14 PM
> To: guyk@marvell.com
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> smadarf@marvell.com; dovrat@marvell.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according to
> device capabilities
> 
> 
> Hi Guy,
> 
> > -----Original Message-----
> > From: guyk@marvell.com <guyk@marvell.com>
> > Sent: Tuesday, October 20, 2020 12:10 PM
> > Subject: [PATCH v1] app/regex: configure qp according to device
> > capabilities
> >
> > From: Guy Kaneti <guyk@marvell.com>
> >
> > configure qp with OOS according to device capabilities returned from
> > rte_regexdev_info_get.
> >
> > Signed-off-by: Guy Kaneti <guyk@marvell.com>
> > ---
> >  app/test-regex/main.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/app/test-regex/main.c b/app/test-regex/main.c index
> > e6080b44b..3deaf3c80 100644
> > --- a/app/test-regex/main.c
> > +++ b/app/test-regex/main.c
> > @@ -173,7 +173,7 @@ init_port(struct rte_mempool **mbuf_mp,
> uint32_t
> > nb_jobs,
> >  	};
> >  	struct rte_regexdev_qp_conf qp_conf = {
> >  		.nb_desc = 1024,
> > -		.qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
> > +		.qp_conf_flags = 0,
> >  	};
> >  	int res = 0;
> >
> > @@ -218,6 +218,8 @@ init_port(struct rte_mempool **mbuf_mp,
> uint32_t
> > nb_jobs,
> >  			printf("Error, can't configure device %d.\n", id);
> >  			goto error;
> >  		}
> > +		if (info.regexdev_capa &
> > RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F)
> > +			qp_conf.qp_conf_flags |=
> > RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
> >  		res = rte_regexdev_queue_pair_setup(id, 0, &qp_conf);
> >  		if (res < 0) {
> >  			printf("Error, can't setup queue pair for device
> %d.\n",
> > --
> > 2.28.0
> 
> Acked-by: Ori Kam <orika@nvidia.com>
> Best,
> Ori
Ophir Munk Oct. 22, 2020, 10:57 a.m. UTC | #3 
Please ignore.
Now I notice it in a follow up commit. 
http://patches.dpdk.org/patch/81673/

> -----Original Message-----
> From: Ophir Munk
> Sent: Thursday, October 22, 2020 1:53 PM
> To: Ori Kam <orika@nvidia.com>; guyk@marvell.com
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> smadarf@marvell.com; dovrat@marvell.com; dev@dpdk.org
> Subject: RE: [PATCH v1] app/regex: configure qp according to device
> capabilities
> 
> Hi Guy,
> I could not find RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F defined in latest
> dpdk/main. As a result my compilation is broken.
> Can you please assist?
> 
> Regards,
> Ophir
>
Guy Kaneti Oct. 22, 2020, 11:12 a.m. UTC | #4 
Hi,

The patch was not merged yet:
https://patches.dpdk.org/patch/81673/

I will rebase this patch once it is merged.

Regards,
Guy 

> -----Original Message-----
> From: Ophir Munk <ophirmu@nvidia.com>
> Sent: Thursday, October 22, 2020 1:53 PM
> To: Ori Kam <orika@nvidia.com>; Guy Kaneti <guyk@marvell.com>
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Smadar Fuks
> <smadarf@marvell.com>; Dovrat Zifroni <dovrat@marvell.com>;
> dev@dpdk.org
> Subject: [EXT] RE: [PATCH v1] app/regex: configure qp according to device
> capabilities
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi Guy,
> I could not find RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F defined in
> latest dpdk/main. As a result my compilation is broken.
> Can you please assist?
> 
> Regards,
> Ophir
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Ori Kam
> > Sent: Tuesday, October 20, 2020 12:14 PM
> > To: guyk@marvell.com
> > Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> > smadarf@marvell.com; dovrat@marvell.com; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according
> > to device capabilities
> >
> >
> > Hi Guy,
> >
> > > -----Original Message-----
> > > From: guyk@marvell.com <guyk@marvell.com>
> > > Sent: Tuesday, October 20, 2020 12:10 PM
> > > Subject: [PATCH v1] app/regex: configure qp according to device
> > > capabilities
> > >
> > > From: Guy Kaneti <guyk@marvell.com>
> > >
> > > configure qp with OOS according to device capabilities returned from
> > > rte_regexdev_info_get.
> > >
> > > Signed-off-by: Guy Kaneti <guyk@marvell.com>
> > > ---
> > >  app/test-regex/main.c | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/app/test-regex/main.c b/app/test-regex/main.c index
> > > e6080b44b..3deaf3c80 100644
> > > --- a/app/test-regex/main.c
> > > +++ b/app/test-regex/main.c
> > > @@ -173,7 +173,7 @@ init_port(struct rte_mempool **mbuf_mp,
> > uint32_t
> > > nb_jobs,
> > >  	};
> > >  	struct rte_regexdev_qp_conf qp_conf = {
> > >  		.nb_desc = 1024,
> > > -		.qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
> > > +		.qp_conf_flags = 0,
> > >  	};
> > >  	int res = 0;
> > >
> > > @@ -218,6 +218,8 @@ init_port(struct rte_mempool **mbuf_mp,
> > uint32_t
> > > nb_jobs,
> > >  			printf("Error, can't configure device %d.\n", id);
> > >  			goto error;
> > >  		}
> > > +		if (info.regexdev_capa &
> > > RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F)
> > > +			qp_conf.qp_conf_flags |=
> > > RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
> > >  		res = rte_regexdev_queue_pair_setup(id, 0, &qp_conf);
> > >  		if (res < 0) {
> > >  			printf("Error, can't setup queue pair for device
> > %d.\n",
> > > --
> > > 2.28.0
> >
> > Acked-by: Ori Kam <orika@nvidia.com>
> > Best,
> > Ori
Thomas Monjalon Nov. 3, 2020, 12:40 a.m. UTC | #5 
> > From: Guy Kaneti <guyk@marvell.com>
> > 
> > configure qp with OOS according to device capabilities
> > returned from rte_regexdev_info_get.
> > 
> > Signed-off-by: Guy Kaneti <guyk@marvell.com>
> 
> Acked-by: Ori Kam <orika@nvidia.com>

Applied, thanks
diff mbox series

Patch

diff --git a/app/test-regex/main.c b/app/test-regex/main.c
index e6080b44b..3deaf3c80 100644
--- a/app/test-regex/main.c
+++ b/app/test-regex/main.c
@@ -173,7 +173,7 @@  init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,
 	};
 	struct rte_regexdev_qp_conf qp_conf = {
 		.nb_desc = 1024,
-		.qp_conf_flags = RTE_REGEX_QUEUE_PAIR_CFG_OOS_F,
+		.qp_conf_flags = 0,
 	};
 	int res = 0;
 
@@ -218,6 +218,8 @@  init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs,
 			printf("Error, can't configure device %d.\n", id);
 			goto error;
 		}
+		if (info.regexdev_capa & RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F)
+			qp_conf.qp_conf_flags |= RTE_REGEX_QUEUE_PAIR_CFG_OOS_F;
 		res = rte_regexdev_queue_pair_setup(id, 0, &qp_conf);
 		if (res < 0) {
 			printf("Error, can't setup queue pair for device %d.\n",