diff mbox series

[RESEND,1/2] raw/octeontx2_dma: Assign pem_id as lport for non-internal DMA

Message ID 20201006053021.134706-1-radhac@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [RESEND,1/2] raw/octeontx2_dma: Assign pem_id as lport for non-internal DMA |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Radha Chintakuntla Oct. 6, 2020, 5:30 a.m. UTC 
  DPI needs to know the PEM number for all external transfers.

Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
Reviewed-by: Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>
Reviewed-by: Satananda Burla <sburla@marvell.com>
---
 drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c | 2 ++
 drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h | 1 +
 2 files changed, 3 insertions(+)

Comments

Satha Koteswara Rao Kottidi Oct. 7, 2020, 4:43 p.m. UTC | #1 
-----Original Message-----
From: Radha Mohan Chintakuntla <radhac@marvell.com> 
Sent: Tuesday, October 6, 2020 11:00 AM
To: dev@dpdk.org; Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Radha Chintakuntla <radhac@marvell.com>; Satananda Burla <sburla@marvell.com>
Subject: [PATCH RESEND 1/2] raw/octeontx2_dma: Assign pem_id as lport for non-internal DMA

DPI needs to know the PEM number for all external transfers.

Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
Reviewed-by: Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>
Reviewed-by: Satananda Burla <sburla@marvell.com>
---

 drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c | 2 ++  drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h | 1 +
 2 files changed, 3 insertions(+)

diff --git a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
index 5b496446c..a1b94ce1d 100644
--- a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
+++ b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
@@ -201,6 +201,8 @@ otx2_dpi_rawdev_enqueue_bufs(struct rte_rawdev *dev,
 		index += 4;
 		hdr->s.fport = 0;
 		hdr->s.lport = 0;
+		if (ctx->xtype !=  DPI_XTYPE_INTERNAL_ONLY)
+			hdr->s.lport = ctx->pem_id;
 
 		/* For inbound case, src pointers are last pointers.
 		 * For all other cases, src pointers are first pointers.
diff --git a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h
index 9ebb25988..81740e84b 100644
--- a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h
+++ b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h
@@ -140,6 +140,7 @@ struct dpi_dma_queue_ctx_s {
 	uint16_t req_type:2;
 	uint16_t use_lock:1;
 	uint16_t deallocv;
+	uint16_t  pem_id;
 
 	struct dpi_cring_data_s *c_ring;
 };
--
2.24.1

Acked-by: Satha Rao <skoteshwar@marvell.com>
Radha Mohan Oct. 9, 2020, 6:18 p.m. UTC | #2 
On Wed, Oct 7, 2020 at 10:33 AM Satha Koteswara Rao Kottidi
<skoteshwar@marvell.com> wrote:
>
>
>
> -----Original Message-----
> From: Radha Mohan Chintakuntla <radhac@marvell.com>
> Sent: Tuesday, October 6, 2020 11:00 AM
> To: dev@dpdk.org; Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Radha Chintakuntla <radhac@marvell.com>; Satananda Burla <sburla@marvell.com>
> Subject: [PATCH RESEND 1/2] raw/octeontx2_dma: Assign pem_id as lport for non-internal DMA
>
> DPI needs to know the PEM number for all external transfers.
>
> Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> Reviewed-by: Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>
> Reviewed-by: Satananda Burla <sburla@marvell.com>
> ---
>
>  drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c | 2 ++  drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h | 1 +
>  2 files changed, 3 insertions(+)
>
> diff --git a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
> index 5b496446c..a1b94ce1d 100644
> --- a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
> +++ b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
> @@ -201,6 +201,8 @@ otx2_dpi_rawdev_enqueue_bufs(struct rte_rawdev *dev,
>                 index += 4;
>                 hdr->s.fport = 0;
>                 hdr->s.lport = 0;
> +               if (ctx->xtype !=  DPI_XTYPE_INTERNAL_ONLY)
> +                       hdr->s.lport = ctx->pem_id;
>
>                 /* For inbound case, src pointers are last pointers.
>                  * For all other cases, src pointers are first pointers.
> diff --git a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h
> index 9ebb25988..81740e84b 100644
> --- a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h
> +++ b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h
> @@ -140,6 +140,7 @@ struct dpi_dma_queue_ctx_s {
>         uint16_t req_type:2;
>         uint16_t use_lock:1;
>         uint16_t deallocv;
> +       uint16_t  pem_id;
>
>         struct dpi_cring_data_s *c_ring;
>  };
> --
> 2.24.1
>
> Acked-by: Satha Rao <skoteshwar@marvell.com>

David/Thomas,
Could you please pick this series for main.

regards,
Radha Mohan
Thomas Monjalon Oct. 11, 2020, 7:57 p.m. UTC | #3 
> DPI needs to know the PEM number for all external transfers.
> 
> Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> Reviewed-by: Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>
> Reviewed-by: Satananda Burla <sburla@marvell.com>
> 
> Acked-by: Satha Rao <skoteshwar@marvell.com>

Series applied, thanks
diff mbox series

Patch

diff --git a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
index 5b496446c..a1b94ce1d 100644
--- a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
+++ b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.c
@@ -201,6 +201,8 @@  otx2_dpi_rawdev_enqueue_bufs(struct rte_rawdev *dev,
 		index += 4;
 		hdr->s.fport = 0;
 		hdr->s.lport = 0;
+		if (ctx->xtype !=  DPI_XTYPE_INTERNAL_ONLY)
+			hdr->s.lport = ctx->pem_id;
 
 		/* For inbound case, src pointers are last pointers.
 		 * For all other cases, src pointers are first pointers.
diff --git a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h
index 9ebb25988..81740e84b 100644
--- a/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h
+++ b/drivers/raw/octeontx2_dma/otx2_dpi_rawdev.h
@@ -140,6 +140,7 @@  struct dpi_dma_queue_ctx_s {
 	uint16_t req_type:2;
 	uint16_t use_lock:1;
 	uint16_t deallocv;
+	uint16_t  pem_id;
 
 	struct dpi_cring_data_s *c_ring;
 };