diff mbox series

[v1,10/15] net/mlx5: rearrange QP creation in Verbs module

Message ID	1601561366-1821-11-git-send-email-michaelba@nvidia.com (mailing list archive)
State	Accepted, archived
Delegated to:	Raslan Darawsheh
Headers	From: Michael Baum <michaelba@nvidia.com> To: dev@dpdk.org Cc: Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com> Date: Thu, 1 Oct 2020 14:09:21 +0000 Message-Id: <1601561366-1821-11-git-send-email-michaelba@nvidia.com> In-Reply-To: <1601561366-1821-1-git-send-email-michaelba@nvidia.com> References: <1601561366-1821-1-git-send-email-michaelba@nvidia.com> Subject: [dpdk-dev] [PATCH v1 10/15] net/mlx5: rearrange QP creation in Verbs module Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	mlx5 Tx DevX/Verbs separation \| [v1,00/15] mlx5 Tx DevX/Verbs separation [v1,01/15] net/mlx5: fix send queue doorbell typo [v1,02/15] net/mlx5: fix unused variable in Txq creation [v1,03/15] net/mlx5: mitigate Tx queue reference counters [v1,04/15] net/mlx5: reorder Tx queue DevX object creation [v1,05/15] net/mlx5: reorder Tx queue Verbs object creation [v1,06/15] net/mlx5: reposition the event queue number field [v1,07/15] net/mlx5: separate Tx queue object creations [v1,08/15] net/mlx5: share Tx control code [v1,09/15] net/mlx5: rearrange SQ and CQ creation in DevX module [v1,10/15] net/mlx5: rearrange QP creation in Verbs module [v1,11/15] net/mlx5: separate Tx queue object modification [v1,12/15] net/mlx5: share Tx queue object modification [v1,13/15] net/mlx5: remove Tx queue object type field [v1,14/15] net/mlx5: separate Rx queue state modification [v1,15/15] net/mlx5: remove Rx queue object type field

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Michael Baum Oct. 1, 2020, 2:09 p.m. UTC

  1. Rename function to mention the internal resources.
2. Reduce the number of function arguments.

Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 drivers/net/mlx5/linux/mlx5_verbs.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/mlx5/linux/mlx5_verbs.c b/drivers/net/mlx5/linux/mlx5_verbs.c
index 5568c75..0476d94 100644
--- a/drivers/net/mlx5/linux/mlx5_verbs.c
+++ b/drivers/net/mlx5/linux/mlx5_verbs.c
@@ -789,15 +789,12 @@ 
  *   Pointer to Ethernet device.
  * @param idx
  *   Queue index in DPDK Tx queue array.
- * @param rxq_obj
- *   Pointer to Tx queue object data.
  *
  * @return
- *   The QP Verbs object initialized, NULL otherwise and rte_errno is set.
+ *   The QP Verbs object, NULL otherwise and rte_errno is set.
  */
 static struct ibv_qp *
-mlx5_ibv_qp_new(struct rte_eth_dev *dev, uint16_t idx,
-		struct mlx5_txq_obj *txq_obj)
+mlx5_txq_ibv_qp_create(struct rte_eth_dev *dev, uint16_t idx)
 {
 	struct mlx5_priv *priv = dev->data->dev_private;
 	struct mlx5_txq_data *txq_data = (*priv->txqs)[idx];
@@ -807,11 +804,11 @@ 
 	struct ibv_qp_init_attr_ex qp_attr = { 0 };
 	const int desc = 1 << txq_data->elts_n;
 
-	MLX5_ASSERT(txq_ctrl->obj);
+	MLX5_ASSERT(txq_ctrl->obj->cq);
 	/* CQ to be associated with the send queue. */
-	qp_attr.send_cq = txq_obj->cq;
+	qp_attr.send_cq = txq_ctrl->obj->cq;
 	/* CQ to be associated with the receive queue. */
-	qp_attr.recv_cq = txq_obj->cq;
+	qp_attr.recv_cq = txq_ctrl->obj->cq;
 	/* Max number of outstanding WRs. */
 	qp_attr.cap.max_send_wr = ((priv->sh->device_attr.max_qp_wr < desc) ?
 				   priv->sh->device_attr.max_qp_wr : desc);
@@ -890,7 +887,7 @@ 
 		rte_errno = errno;
 		goto error;
 	}
-	txq_obj->qp = mlx5_ibv_qp_new(dev, idx, txq_obj);
+	txq_obj->qp = mlx5_txq_ibv_qp_create(dev, idx);
 	if (txq_obj->qp == NULL) {
 		rte_errno = errno;
 		goto error;