From patchwork Mon Sep 28 06:55:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Li Zhang X-Patchwork-Id: 78969 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E0F5A04C0; Mon, 28 Sep 2020 08:55:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ECC701D5F5; Mon, 28 Sep 2020 08:55:54 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 021F31D5F3 for ; Mon, 28 Sep 2020 08:55:50 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from lizh@nvidia.com) with SMTP; 28 Sep 2020 09:55:49 +0300 Received: from nvidia.com (c-234-234-1-007.mtl.labs.mlnx [10.234.234.7]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 08S6tmgq028168; Mon, 28 Sep 2020 09:55:48 +0300 From: Li Zhang To: dekelp@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com Date: Mon, 28 Sep 2020 09:55:46 +0300 Message-Id: <20200928065546.26742-1-lizh@nvidia.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH V1 1/1] net/mlx5: support item type error message in flow Verbs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Update the flow verbs error message to "item type X not supported", when it is not supported, instead of a generic error message "item not supported". Signed-off-by: Li Zhang Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_verbs.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c b/drivers/net/mlx5/mlx5_flow_verbs.c index 62c18b834f..0e0042f17b 100644 --- a/drivers/net/mlx5/mlx5_flow_verbs.c +++ b/drivers/net/mlx5/mlx5_flow_verbs.c @@ -1258,6 +1258,7 @@ flow_verbs_validate(struct rte_eth_dev *dev, uint64_t last_item = 0; uint8_t next_protocol = 0xff; uint16_t ether_type = 0; + char errstr[32]; if (items == NULL) return -1; @@ -1408,9 +1409,11 @@ flow_verbs_validate(struct rte_eth_dev *dev, last_item = MLX5_FLOW_LAYER_MPLS; break; default: + snprintf(errstr, sizeof(errstr), "item type %d not supported", + items->type); return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ITEM, - NULL, "item not supported"); + NULL, errstr); } item_flags |= last_item; } @@ -1704,6 +1707,7 @@ flow_verbs_translate(struct rte_eth_dev *dev, struct mlx5_flow_rss_desc *rss_desc = &((struct mlx5_flow_rss_desc *) priv->rss_desc) [!!priv->flow_nested_idx]; + char errstr[32]; if (priority == MLX5_FLOW_PRIO_RSVD) priority = priv->config.flow_prio - 1; @@ -1849,10 +1853,11 @@ flow_verbs_translate(struct rte_eth_dev *dev, item_flags |= MLX5_FLOW_LAYER_MPLS; break; default: + snprintf(errstr, sizeof(errstr), "item type %d not supported", + items->type); return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ITEM, - NULL, - "item not supported"); + NULL, errstr); } } dev_flow->handle->layers = item_flags;