From patchwork Tue Sep 22 07:06:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Somnath Kotur X-Patchwork-Id: 78232 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A99EAA04E1; Tue, 22 Sep 2020 09:13:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 718CD1D693; Tue, 22 Sep 2020 09:13:24 +0200 (CEST) Received: from relay.smtp-ext.broadcom.com (unknown [192.19.221.30]) by dpdk.org (Postfix) with ESMTP id 739711D567; Tue, 22 Sep 2020 09:13:20 +0200 (CEST) Received: from dhcp-10-123-153-55.dhcp.broadcom.net (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 0A1EF42A1D; Tue, 22 Sep 2020 00:13:18 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 0A1EF42A1D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1600758799; bh=aHOULOn9dUWo/59UbZKv//feVDUNv9CIA07nhQNaIj4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dVuwoHUFMJ6ynSyxz7l6ilCsnHqXL5HTfh99pc+ZaFCClkzYkCZeO4Vxq6r0khM0S V9K3ibn9oH8B4rRY3vMNekpAH6ucJve07WplXdV2LndUO1ASwm0Rlfqru2s4rpFORp m4A1cR57JQ/ufs6uCBPydIK4Zvy2qoluIBQAiYEU= From: Somnath Kotur To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Somnath Kotur , stable@dpdk.org, Venkat Duvvuru , Ajit Kumar Khaparde Date: Tue, 22 Sep 2020 12:36:27 +0530 Message-Id: <20200922070632.17706-4-somnath.kotur@broadcom.com> X-Mailer: git-send-email 2.28.0.450.g3a238e5 In-Reply-To: <20200922070632.17706-1-somnath.kotur@broadcom.com> References: <20200922070632.17706-1-somnath.kotur@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/8] net/bnxt: fix to correct bad shift operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In page_roundup() left shifting by more than 31 bits could have undefined behavior as the return value is int and in page_getenum() it is possible to return a value as high as 63. Fix that to cap the return value to less than 32. Coverity issue: 343463 Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Cc: stable@dpdk.org Signed-off-by: Somnath Kotur Reviewed-by: Venkat Duvvuru Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 57d1026..04eb05e 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -52,7 +52,7 @@ static int page_getenum(size_t size) if (size <= 1 << 30) return 30; PMD_DRV_LOG(ERR, "Page size %zu out of range\n", size); - return sizeof(void *) * 8 - 1; + return sizeof(int) * 8 - 1; } static int page_roundup(size_t size)