[1/2] Fix build of apps with external dependencies
diff mbox series

Message ID 20200915083836.18805-2-felix.moessbauer@siemens.com
State New
Delegated to: David Marchand
Headers show
Series
  • [1/2] Fix build of apps with external dependencies
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Felix Moessbauer Sept. 15, 2020, 8:38 a.m. UTC
This fix initializes the dependency object with the external
dependency list. Previously, the external dependencies were
just ignored.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 app/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Oct. 20, 2020, 2:12 p.m. UTC | #1
15/09/2020 10:38, Felix Moessbauer:
> This fix initializes the dependency object with the external
> dependency list. Previously, the external dependencies were
> just ignored.
> 
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
> --- a/app/meson.build
> +++ b/app/meson.build
>  	if build
> -		dep_objs = []
> +		dep_objs = ext_deps

Bruce, do you confirm this is required?
Bruce Richardson Oct. 20, 2020, 2:32 p.m. UTC | #2
On Tue, Oct 20, 2020 at 04:12:58PM +0200, Thomas Monjalon wrote:
> 15/09/2020 10:38, Felix Moessbauer:
> > This fix initializes the dependency object with the external
> > dependency list. Previously, the external dependencies were
> > just ignored.
> > 
> > Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> > ---
> > --- a/app/meson.build
> > +++ b/app/meson.build
> >  	if build
> > -		dep_objs = []
> > +		dep_objs = ext_deps
> 
> Bruce, do you confirm this is required?
> 
Yes, it looks a correct fix, as indeed the ext_deps value is ignored in the
file.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Patch
diff mbox series

diff --git a/app/meson.build b/app/meson.build
index eb74f215a..ab43a8403 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -43,7 +43,7 @@  foreach app:apps
 	subdir(name)
 
 	if build
-		dep_objs = []
+		dep_objs = ext_deps
 		foreach d:deps
 			dep_objs += get_variable(get_option('default_library')
 				 + '_rte_' + d)