net/mlx5: fix vectorized Rx burst check
diff mbox series

Message ID 1600025619-6369-1-git-send-email-viacheslavo@nvidia.com
State Accepted
Delegated to: Raslan Darawsheh
Headers show
Series
  • net/mlx5: fix vectorized Rx burst check
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Slava Ovsiienko Sept. 13, 2020, 7:33 p.m. UTC
The Rx queue start/stop feature is not supported if vectorized
rx_burst routine is engaged. There was a routine address typo
and rx_burst type check was wrong.

Fixes: 161d103b231c ("net/mlx5: add queue start and stop")

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx5/mlx5_rxq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matan Azrad Sept. 17, 2020, 11:20 a.m. UTC | #1
From: Viacheslav Ovsiienko
> The Rx queue start/stop feature is not supported if vectorized rx_burst
> routine is engaged. There was a routine address typo and rx_burst type
> check was wrong.
> 
> Fixes: 161d103b231c ("net/mlx5: add queue start and stop")
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
Raslan Darawsheh Sept. 23, 2020, 7:37 a.m. UTC | #2
Hi,

> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Sent: Sunday, September 13, 2020 10:34 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH] net/mlx5: fix vectorized Rx burst check
> 
> The Rx queue start/stop feature is not supported if vectorized
> rx_burst routine is engaged. There was a routine address typo
> and rx_burst type check was wrong.
> 
> Fixes: 161d103b231c ("net/mlx5: add queue start and stop")
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
>  drivers/net/mlx5/mlx5_rxq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index 0b3e813..1aee6d1 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -562,7 +562,7 @@
>  	 * The routine pointer depends on the process
>  	 * type, should perform check there.
>  	 */
> -	if (pkt_burst == mlx5_rx_burst) {
> +	if (pkt_burst == mlx5_rx_burst_vec) {
>  		DRV_LOG(ERR, "Rx queue stop is not supported "
>  			"for vectorized Rx");
>  		rte_errno = EINVAL;
> --
> 1.8.3.1

Patch applied to next-net-mxl,

Kindest regards,
Raslan Darawsheh

Patch
diff mbox series

diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 0b3e813..1aee6d1 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -562,7 +562,7 @@ 
 	 * The routine pointer depends on the process
 	 * type, should perform check there.
 	 */
-	if (pkt_burst == mlx5_rx_burst) {
+	if (pkt_burst == mlx5_rx_burst_vec) {
 		DRV_LOG(ERR, "Rx queue stop is not supported "
 			"for vectorized Rx");
 		rte_errno = EINVAL;