[18/22] event/dlb2: add PMD's token pop public interface
Checks
Commit Message
The PMD uses a public interface to allow applications to
control the token pop mode. Supported token pop modes are
as follows, and they impact core scheduling affinity for
ldb ports.
AUTO_POP: Pop the CQ tokens immediately after dequeueing.
DELAYED_POP: Pop CQ tokens after (dequeue_depth - 1) events
are released. Supported on load-balanced ports
only.
DEFERRED_POP: Pop the CQ tokens during next dequeue operation.
Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
drivers/event/dlb2/meson.build | 5 ++-
drivers/event/dlb2/rte_pmd_dlb2.c | 39 +++++++++++++++++++++++
drivers/event/dlb2/rte_pmd_dlb2_event_version.map | 6 ++++
3 files changed, 49 insertions(+), 1 deletion(-)
create mode 100644 drivers/event/dlb2/rte_pmd_dlb2.c
Comments
> -----Original Message-----
> From: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Sent: Friday, September 11, 2020 3:26 PM
> To: Ray Kinsella <mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>
> Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carrillo@intel.com>; Eads, Gage
> <gage.eads@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> jerinj@marvell.com
> Subject: [PATCH 18/22] event/dlb2: add PMD's token pop public interface
>
> The PMD uses a public interface to allow applications to
> control the token pop mode. Supported token pop modes are
> as follows, and they impact core scheduling affinity for
> ldb ports.
>
> AUTO_POP: Pop the CQ tokens immediately after dequeueing.
> DELAYED_POP: Pop CQ tokens after (dequeue_depth - 1) events
> are released. Supported on load-balanced ports
> only.
> DEFERRED_POP: Pop the CQ tokens during next dequeue operation.
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> ---
> drivers/event/dlb2/meson.build | 5 ++-
> drivers/event/dlb2/rte_pmd_dlb2.c | 39 +++++++++++++++++++++++
> drivers/event/dlb2/rte_pmd_dlb2_event_version.map | 6 ++++
Should rte_pmd_dlb2.h be listed in doc/api/doxy-api-index.md, so it's included
in the doxygen docs?
Besides that, and the build error related to the experimental tag mentioned in
another review, this looks good to me.
Thanks,
Gage
@@ -1,3 +1,4 @@
+
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2019-2020 Intel Corporation
@@ -6,7 +7,9 @@ sources = files('dlb2.c',
'dlb2_xstats.c',
'pf/dlb2_main.c',
'pf/dlb2_pf.c',
- 'pf/base/dlb2_resource.c'
+ 'pf/base/dlb2_resource.c',
+ 'rte_pmd_dlb2.c'
)
deps += ['mbuf', 'mempool', 'ring', 'bus_vdev', 'pci', 'bus_pci']
+install_headers('rte_pmd_dlb2.h')
\ No newline at end of file
new file mode 100644
@@ -0,0 +1,39 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2020 Intel Corporation
+ */
+
+#include <rte_eventdev.h>
+#include <rte_eventdev_pmd.h>
+
+#include "rte_pmd_dlb2.h"
+#include "dlb2_priv.h"
+#include "dlb2_inline_fns.h"
+
+int
+rte_pmd_dlb2_set_token_pop_mode(uint8_t dev_id,
+ uint8_t port_id,
+ enum dlb2_token_pop_mode mode)
+{
+ struct dlb2_eventdev *dlb2;
+ struct rte_eventdev *dev;
+
+ RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
+ dev = &rte_eventdevs[dev_id];
+
+ dlb2 = dlb2_pmd_priv(dev);
+
+ if (mode >= NUM_TOKEN_POP_MODES)
+ return -EINVAL;
+
+ /* The event device must be configured, but not yet started */
+ if (!dlb2->configured || dlb2->run_state != DLB2_RUN_STATE_STOPPED)
+ return -EINVAL;
+
+ /* The token pop mode must be set before configuring the port */
+ if (port_id >= dlb2->num_ports || dlb2->ev_ports[port_id].setup_done)
+ return -EINVAL;
+
+ dlb2->ev_ports[port_id].qm_port.token_pop_mode = mode;
+
+ return 0;
+}
@@ -1,3 +1,9 @@
DPDK_21.0 {
local: *;
};
+
+EXPERIMENTAL {
+ global:
+
+ rte_pmd_dlb2_set_token_pop_mode;
+};