[v2,1/3] config: remove explicit undefinition of unset values
diff mbox series

Message ID 20200903144942.671870-2-bruce.richardson@intel.com
State Rejected, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • Allow overriding of build-time constants
Related show

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

Richardson, Bruce Sept. 3, 2020, 2:49 p.m. UTC
Rather than explicitly clearing any setting of undefined values in our
rte_config.h file, it's better to instead just add a comment that the value
is not set. Using a comment allows the user to set the value using CFLAGS
or similar mechanism without the config file clearing the value again.

The text used "<VALUE> is not set" is modelled after the kernel approach of
doing the same thing.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---

Although DPDK coding convention forbids use of "//" for comments, using
regular C comment style makes the config settings less clear, as they can
be confused with regular comments in the file. Using "//" makes them stand
out better, so I prefer it. However, if others feel strongly, they can be
changed to standard.
---
 config/rte_config.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Patch
diff mbox series

diff --git a/config/rte_config.h b/config/rte_config.h
index 9bb915347..1c5a86d6a 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -85,17 +85,17 @@ 
 
 /* ip_fragmentation defines */
 #define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4
-#undef RTE_LIBRTE_IP_FRAG_TBL_STAT
+// RTE_LIBRTE_IP_FRAG_TBL_STAT is not set
 
 /* rte_power defines */
 #define RTE_MAX_LCORE_FREQS 64
 
 /* rte_sched defines */
-#undef RTE_SCHED_RED
-#undef RTE_SCHED_COLLECT_STATS
-#undef RTE_SCHED_SUBPORT_TC_OV
+// RTE_SCHED_RED is not set
+// RTE_SCHED_COLLECT_STATS is not set
+// RTE_SCHED_SUBPORT_TC_OV is not set
 #define RTE_SCHED_PORT_N_GRINDERS 8
-#undef RTE_SCHED_VECTOR
+// RTE_SCHED_VECTOR is not set
 
 /* KNI defines */
 #define RTE_KNI_PREEMPT_DEFAULT 1
@@ -123,7 +123,7 @@ 
 
 /* i40e defines */
 #define RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC 1
-#undef RTE_LIBRTE_I40E_16BYTE_RX_DESC
+// RTE_LIBRTE_I40E_16BYTE_RX_DESC is not set
 #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF 64
 #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4
 #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM 4