diff mbox series

[v2,13/17] net/virtio: add checks for max SIMD bitwidth

Message ID	20200827161304.32300-14-ciara.power@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	David Marchand
Headers	IronPort-SDR: 9ifqdkBSvxbZYyB+rJizRD3ReLExqwv29OcKID/YCyDUrXCyf0W53PcULl8Aq0C7xHSHItKwwl z4PQGYl5WIEQ== IronPort-SDR: HNCDfeQdwl10IBFFUmm50R8/a1EpQZ0WWh+rReFcZ3cLmDDx/9fmnRB+qciaJUZz3CgamNTKKP V5BiwWz/rurQ== From: Ciara Power <ciara.power@intel.com> To: dev@dpdk.org Cc: Ciara Power <ciara.power@intel.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, Chenbo Xia <chenbo.xia@intel.com>, Zhihong Wang <zhihong.wang@intel.com> Date: Thu, 27 Aug 2020 17:13:00 +0100 Message-Id: <20200827161304.32300-14-ciara.power@intel.com> In-Reply-To: <20200827161304.32300-1-ciara.power@intel.com> References: <20200807155859.63888-1-ciara.power@intel.com> <20200827161304.32300-1-ciara.power@intel.com> Subject: [dpdk-dev] [PATCH v2 13/17] net/virtio: add checks for max SIMD bitwidth Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	add max SIMD bitwidth to EAL \| [v2,00/17] add max SIMD bitwidth to EAL [v2,01/17] eal: add max SIMD bitwidth [v2,02/17] eal: add default SIMD bitwidth values [v2,03/17] doc: add detail on using max SIMD bitwidth [v2,04/17] net/i40e: add checks for max SIMD bitwidth [v2,05/17] net/axgbe: add checks for max SIMD bitwidth [v2,06/17] net/bnxt: add checks for max SIMD bitwidth [v2,07/17] net/enic: add checks for max SIMD bitwidth [v2,08/17] net/fm10k: add checks for max SIMD bitwidth [v2,09/17] net/iavf: add checks for max SIMD bitwidth [v2,10/17] net/ice: add checks for max SIMD bitwidth [v2,11/17] net/ixgbe: add checks for max SIMD bitwidth [v2,12/17] net/mlx5: add checks for max SIMD bitwidth [v2,13/17] net/virtio: add checks for max SIMD bitwidth [v2,14/17] distributor: add checks for max SIMD bitwidth [v2,15/17] member: add checks for max SIMD bitwidth [v2,16/17] efd: add checks for max SIMD bitwidth [v2,17/17] net: add checks for max SIMD bitwidth

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Power, Ciara Aug. 27, 2020, 4:13 p.m. UTC

  When choosing a vector path to take, an extra condition must be
satisfied to ensure the max SIMD bitwidth allows for the CPU enabled
path.

Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Chenbo Xia <chenbo.xia@intel.com>
Cc: Zhihong Wang <zhihong.wang@intel.com>

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 drivers/net/virtio/virtio_ethdev.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comments

Chenbo Xia Aug. 31, 2020, 2:39 a.m. UTC | #1

Hi Ciara,

Sorry for late response and thanks for working on this! Currently virtio
driver puts all vector-related conditions in dev_configure (virtio_dev_configure).
Do you think it's ok to put all below code logic to dev_configure?

Thanks!
Chenbo

> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Friday, August 28, 2020 12:13 AM
> To: dev@dpdk.org
> Cc: Power, Ciara <ciara.power@intel.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Xia, Chenbo <chenbo.xia@intel.com>; Wang,
> Zhihong <zhihong.wang@intel.com>
> Subject: [PATCH v2 13/17] net/virtio: add checks for max SIMD bitwidth
> 
> When choosing a vector path to take, an extra condition must be
> satisfied to ensure the max SIMD bitwidth allows for the CPU enabled
> path.
> 
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Cc: Chenbo Xia <chenbo.xia@intel.com>
> Cc: Zhihong Wang <zhihong.wang@intel.com>
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
>  drivers/net/virtio/virtio_ethdev.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c
> b/drivers/net/virtio/virtio_ethdev.c
> index dc0093bdf0..f779ce8396 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1517,9 +1517,11 @@ set_rxtx_funcs(struct rte_eth_dev *eth_dev)
>  	if (vtpci_packed_queue(hw)) {
>  		PMD_INIT_LOG(INFO,
>  			"virtio: using packed ring %s Tx path on port %u",
> -			hw->use_vec_tx ? "vectorized" : "standard",
> +			(hw->use_vec_tx && rte_get_max_simd_bitwidth()
> +			> RTE_MAX_256_SIMD) ? "vectorized" : "standard",
>  			eth_dev->data->port_id);
> -		if (hw->use_vec_tx)
> +		if (hw->use_vec_tx && rte_get_max_simd_bitwidth()
> +				> RTE_MAX_256_SIMD)
>  			eth_dev->tx_pkt_burst = virtio_xmit_pkts_packed_vec;
>  		else
>  			eth_dev->tx_pkt_burst = virtio_xmit_pkts_packed;
> @@ -1536,7 +1538,8 @@ set_rxtx_funcs(struct rte_eth_dev *eth_dev)
>  	}
> 
>  	if (vtpci_packed_queue(hw)) {
> -		if (hw->use_vec_rx) {
> +		if (hw->use_vec_rx && rte_get_max_simd_bitwidth()
> +				> RTE_MAX_256_SIMD) {
>  			PMD_INIT_LOG(INFO,
>  				"virtio: using packed ring vectorized Rx path on
> port %u",
>  				eth_dev->data->port_id);
> @@ -1555,7 +1558,8 @@ set_rxtx_funcs(struct rte_eth_dev *eth_dev)
>  			eth_dev->rx_pkt_burst = &virtio_recv_pkts_packed;
>  		}
>  	} else {
> -		if (hw->use_vec_rx) {
> +		if (hw->use_vec_rx && rte_get_max_simd_bitwidth()
> +				>= RTE_MAX_128_SIMD) {
>  			PMD_INIT_LOG(INFO, "virtio: using vectorized Rx path on
> port %u",
>  				eth_dev->data->port_id);
>  			eth_dev->rx_pkt_burst = virtio_recv_pkts_vec;
> --
> 2.17.1

diff mbox series

Patch

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index dc0093bdf0..f779ce8396 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1517,9 +1517,11 @@  set_rxtx_funcs(struct rte_eth_dev *eth_dev)
 	if (vtpci_packed_queue(hw)) {
 		PMD_INIT_LOG(INFO,
 			"virtio: using packed ring %s Tx path on port %u",
-			hw->use_vec_tx ? "vectorized" : "standard",
+			(hw->use_vec_tx && rte_get_max_simd_bitwidth()
+			> RTE_MAX_256_SIMD) ? "vectorized" : "standard",
 			eth_dev->data->port_id);
-		if (hw->use_vec_tx)
+		if (hw->use_vec_tx && rte_get_max_simd_bitwidth()
+				> RTE_MAX_256_SIMD)
 			eth_dev->tx_pkt_burst = virtio_xmit_pkts_packed_vec;
 		else
 			eth_dev->tx_pkt_burst = virtio_xmit_pkts_packed;
@@ -1536,7 +1538,8 @@  set_rxtx_funcs(struct rte_eth_dev *eth_dev)
 	}
 
 	if (vtpci_packed_queue(hw)) {
-		if (hw->use_vec_rx) {
+		if (hw->use_vec_rx && rte_get_max_simd_bitwidth()
+				> RTE_MAX_256_SIMD) {
 			PMD_INIT_LOG(INFO,
 				"virtio: using packed ring vectorized Rx path on port %u",
 				eth_dev->data->port_id);
@@ -1555,7 +1558,8 @@  set_rxtx_funcs(struct rte_eth_dev *eth_dev)
 			eth_dev->rx_pkt_burst = &virtio_recv_pkts_packed;
 		}
 	} else {
-		if (hw->use_vec_rx) {
+		if (hw->use_vec_rx && rte_get_max_simd_bitwidth()
+				>= RTE_MAX_128_SIMD) {
 			PMD_INIT_LOG(INFO, "virtio: using vectorized Rx path on port %u",
 				eth_dev->data->port_id);
 			eth_dev->rx_pkt_burst = virtio_recv_pkts_vec;