diff mbox series

[v2,1/6] net/iavf: fix scattered Rx enabling

Message ID	20200827011410.18401-2-stevex.yang@intel.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Qi Zhang
Headers	IronPort-SDR: 9HCJY8AQnvo8HuN8aKjc9khfO4aLkIwT5NKpKnN50v+YDGkZRE57GIPXj2xxVELd1BCAOBPVs9 NoRye1PdHY8Q== IronPort-SDR: 0tpwPt1VIPxYumR/QxY8H1SHbZcbh4ztKayli9LOm5Kpt4biE3qTPlezHSPEXFGNilGuTHCKW/ 7b01j4E/uFYQ== From: SteveX Yang <stevex.yang@intel.com> To: dev@dpdk.org Cc: qiming.yang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, SteveX Yang <stevex.yang@intel.com> Date: Thu, 27 Aug 2020 01:14:05 +0000 Message-Id: <20200827011410.18401-2-stevex.yang@intel.com> In-Reply-To: <20200827011410.18401-1-stevex.yang@intel.com> References: <20200811075910.20954-1-stevex.yang@intel.com> <20200827011410.18401-1-stevex.yang@intel.com> Subject: [dpdk-dev] [PATCH v2 1/6] net/iavf: fix scattered Rx enabling Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	[v2,1/6] net/iavf: fix scattered Rx enabling \| [v2,1/6] net/iavf: fix scattered Rx enabling [v2,2/6] net/iavf: set speed to undefined for default case [v2,3/6] net/iavf: fix port start during configuration restore [v2,4/6] net/iavf: fix setting of MAC address on iavf [v2,5/6] net/iavf: fix multiple interrupts for VF [v2,6/6] net/iavf: downgrade error log

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Steve Yang Aug. 27, 2020, 1:14 a.m. UTC

  No need to add additional vlan tag size for max packet size, since
for i40e, the queue's Rx Max Frame Size (rxq->max_pkt_len) already
includes the vlan header size.

Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")

Signed-off-by: SteveX Yang <stevex.yang@intel.com>
---
 drivers/net/iavf/iavf_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xing, Beilei Aug. 27, 2020, 2:49 a.m. UTC | #1

> -----Original Message-----
> From: Yang, SteveX <stevex.yang@intel.com>
> Sent: Thursday, August 27, 2020 9:14 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>
> Subject: [PATCH v2 1/6] net/iavf: fix scattered Rx enabling
> 
> No need to add additional vlan tag size for max packet size, since for i40e, the

Seems my comment in v1 patch is not addressed.

> queue's Rx Max Frame Size (rxq->max_pkt_len) already includes the vlan
> header size.
> 
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
> 
> Signed-off-by: SteveX Yang <stevex.yang@intel.com>
> ---
>  drivers/net/iavf/iavf_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index c3aa4cd72..f9dd5710c 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -253,7 +253,7 @@ iavf_init_rxq(struct rte_eth_dev *dev, struct
> iavf_rx_queue *rxq)
> 
>  	rxq->max_pkt_len = max_pkt_len;
>  	if ((dev_data->dev_conf.rxmode.offloads &
> DEV_RX_OFFLOAD_SCATTER) ||
> -	    (rxq->max_pkt_len + 2 * IAVF_VLAN_TAG_SIZE) > buf_size) {
> +	    rxq->max_pkt_len > buf_size) {
>  		dev_data->scattered_rx = 1;
>  	}
>  	IAVF_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1);
> --
> 2.17.1

diff mbox series

Patch

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index c3aa4cd72..f9dd5710c 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -253,7 +253,7 @@  iavf_init_rxq(struct rte_eth_dev *dev, struct iavf_rx_queue *rxq)
 
 	rxq->max_pkt_len = max_pkt_len;
 	if ((dev_data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_SCATTER) ||
-	    (rxq->max_pkt_len + 2 * IAVF_VLAN_TAG_SIZE) > buf_size) {
+	    rxq->max_pkt_len > buf_size) {
 		dev_data->scattered_rx = 1;
 	}
 	IAVF_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1);