diff mbox series

[v2,2/3] app/testpmd: add Rx buffer size display in queue info query

Message ID 1598425943-61981-3-git-send-email-tangchengchang@huawei.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series [RFC] ethdev: add a field for rte_eth_rxq_info |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Chengchang Tang Aug. 26, 2020, 7:12 a.m. UTC 
  Add Rx buffer size to queue info querry cmd so that the user can get the
buffer length used by HW queue for receiving packets.

Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
---
v1 -> v2: fix some spelling mistake
---
 app/test-pmd/config.c | 1 +
 1 file changed, 1 insertion(+)

--
2.7.4

Comments

Wei Hu (Xavier) Aug. 26, 2020, 7:28 a.m. UTC | #1 
On 2020/8/26 15:12, Chengchang Tang wrote:
> Add Rx buffer size to queue info querry cmd so that the user can get the
> buffer length used by HW queue for receiving packets.
>
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> ---
> v1 -> v2: fix some spelling mistake
> ---
>   app/test-pmd/config.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 30bee33..b432ac6 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -452,6 +452,7 @@ rx_queue_infos_display(portid_t port_id, uint16_t queue_id)
>   		(qinfo.conf.rx_deferred_start != 0) ? "on" : "off");
>   	printf("\nRX scattered packets: %s",
>   		(qinfo.scattered_rx != 0) ? "on" : "off");
> +	printf("\nRX buffer size: %hu", qinfo.rx_buf_size);
>   	printf("\nNumber of RXDs: %hu", qinfo.nb_desc);
>
>   	if (rte_eth_rx_burst_mode_get(port_id, queue_id, &mode) == 0)
> --
> 2.7.4
>
Stephen Hemminger Aug. 26, 2020, 2:42 p.m. UTC | #2 
On Wed, 26 Aug 2020 15:12:22 +0800
Chengchang Tang <tangchengchang@huawei.com> wrote:

> Add Rx buffer size to queue info querry cmd so that the user can get the
> buffer length used by HW queue for receiving packets.
> 
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>

You might want to add this info to proc-info tool as well.
Chengchang Tang Aug. 29, 2020, 6:48 a.m. UTC | #3 
Hi, Stephen Hemminger

On 2020/8/26 22:42, Stephen Hemminger wrote:
> On Wed, 26 Aug 2020 15:12:22 +0800
> Chengchang Tang <tangchengchang@huawei.com> wrote:
> 
>> Add Rx buffer size to queue info querry cmd so that the user can get the
>> buffer length used by HW queue for receiving packets.
>>
>> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> 
> You might want to add this info to proc-info tool as well.
> 
> .
> 
Thanks for your suggestion.

I will add this to proc-info tool in the next version.

Thanks, Chengchang
diff mbox series

Patch

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 30bee33..b432ac6 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -452,6 +452,7 @@  rx_queue_infos_display(portid_t port_id, uint16_t queue_id)
 		(qinfo.conf.rx_deferred_start != 0) ? "on" : "off");
 	printf("\nRX scattered packets: %s",
 		(qinfo.scattered_rx != 0) ? "on" : "off");
+	printf("\nRX buffer size: %hu", qinfo.rx_buf_size);
 	printf("\nNumber of RXDs: %hu", qinfo.nb_desc);

 	if (rte_eth_rx_burst_mode_get(port_id, queue_id, &mode) == 0)