diff mbox series

[v2] net/virtio: fix 57f90f8("net/virtio: reuse packed ring functions")

Message ID 20200810195958.1239-1-vipul.ashri@oracle.com (mailing list archive)
State Superseded, archived
Delegated to: Maxime Coquelin
Headers
Series [v2] net/virtio: fix 57f90f8("net/virtio: reuse packed ring functions") |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS

Commit Message

Vipul Ashri Aug. 10, 2020, 7:59 p.m. UTC 
  tx packets are not going out and standard tx path is not working due to
cleanup malfunctioning.

Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com>
---
 drivers/net/virtio/virtqueue.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Chenbo Xia Aug. 12, 2020, noon UTC | #1 
Hi Vipul,

> -----Original Message-----
> From: Vipul Ashri <vipul.ashri@oracle.com>
> Sent: Wednesday, August 12, 2020 5:23 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; vipul.ashri@oracle.com;
> edwin.leung@oracle.com
> Subject: [PATCH v2] Fixes: 57f90f894588("net/virtio: reuse packed ring
> functions")
> 
> Problem - Standard Tx packets are not going out and found broken
>  due to cleanup malfunctioning whereever below mentioned macro is
>  used.
> 
> RootCause - Here inside Macro 'ASSIGN_UNLESS_EQUAL(var, val)'
>  assignment to 'var' argument passed is always failing as assignment
>  done using 'var_' having local scope only.
> 
> Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com>

I understand now. Your patch makes sense. But your commit title/msg is still
wrong. An example commit message should be (you could use this):

net/virtio: fix wrong variable assignment in helper macro

Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always failing
as assignment done using var_ having local scope only. This leads to TX packets
not going out and found broken due to cleanup malfunctioning. This patch fixes
the wrong variable assignment.

Fixes: 57f90f894588("net/virtio: reuse packed ring functions")
Cc: stable@dpdk.org

Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com>

> ---
>  drivers/net/virtio/virtqueue.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtqueue.h
> b/drivers/net/virtio/virtqueue.h
> index 105a9c00c..20c95471e 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq)
> 
>  /* avoid write operation when necessary, to lessen cache issues */
>  #define ASSIGN_UNLESS_EQUAL(var, val) do {	\
> -	typeof(var) var_ = (var);		\
> -	typeof(val) val_ = (val);		\
> -	if ((var_) != (val_))			\
> -		(var_) = (val_);		\
> +	if ((var) != (val))			\
> +		(var) = (val);			\
>  } while (0)
> 
>  #define virtqueue_clear_net_hdr(hdr) do {		\
> --
> 2.28.0.windows.1
Vipul Ashri Aug. 13, 2020, 7:23 a.m. UTC | #2 
Hi Javin

FYI
http://patches.dpdk.org/patch/75476/
The mentioned fix you are trying to submit is already addressed and in review with Xia chenbo since 10th august.
Hope you can discard your patch as I have already sent the patch to dpdk community.

Regards
Vipul

-----Original Message-----
From: Xia, Chenbo [mailto:chenbo.xia@intel.com] 
Sent: Wednesday, 12 August, 2020 17:31
To: Vipul Ashri <vipul.ashri@oracle.com>; dev@dpdk.org
Cc: Edwin Leung <edwin.leung@oracle.com>
Subject: RE: [PATCH v2] Fixes: 57f90f894588("net/virtio: reuse packed ring functions")

Hi Vipul,

> -----Original Message-----
> From: Vipul Ashri <vipul.ashri@oracle.com>
> Sent: Wednesday, August 12, 2020 5:23 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; vipul.ashri@oracle.com; 
> edwin.leung@oracle.com
> Subject: [PATCH v2] Fixes: 57f90f894588("net/virtio: reuse packed ring
> functions")
> 
> Problem - Standard Tx packets are not going out and found broken  due 
> to cleanup malfunctioning whereever below mentioned macro is  used.
> 
> RootCause - Here inside Macro 'ASSIGN_UNLESS_EQUAL(var, val)'
>  assignment to 'var' argument passed is always failing as assignment  
> done using 'var_' having local scope only.
> 
> Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com>

I understand now. Your patch makes sense. But your commit title/msg is still wrong. An example commit message should be (you could use this):

net/virtio: fix wrong variable assignment in helper macro

Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always failing as assignment done using var_ having local scope only. This leads to TX packets not going out and found broken due to cleanup malfunctioning. This patch fixes the wrong variable assignment.

Fixes: 57f90f894588("net/virtio: reuse packed ring functions")
Cc: stable@dpdk.org

Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com>

> ---
>  drivers/net/virtio/virtqueue.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtqueue.h 
> b/drivers/net/virtio/virtqueue.h index 105a9c00c..20c95471e 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq)
> 
>  /* avoid write operation when necessary, to lessen cache issues */
>  #define ASSIGN_UNLESS_EQUAL(var, val) do {	\
> -	typeof(var) var_ = (var);		\
> -	typeof(val) val_ = (val);		\
> -	if ((var_) != (val_))			\
> -		(var_) = (val_);		\
> +	if ((var) != (val))			\
> +		(var) = (val);			\
>  } while (0)
> 
>  #define virtqueue_clear_net_hdr(hdr) do {		\
> --
> 2.28.0.windows.1
chupenghong Aug. 13, 2020, 7:27 a.m. UTC | #3 
OK !









At 2020-08-13 15:23:01, "Vipul Ashri" <vipul.ashri@oracle.com> wrote:
>Hi Javin
>
>FYI
>http://patches.dpdk.org/patch/75476/
>The mentioned fix you are trying to submit is already addressed and in review with Xia chenbo since 10th august.
>Hope you can discard your patch as I have already sent the patch to dpdk community.
>
>Regards
>Vipul
>
>-----Original Message-----
>From: Xia, Chenbo [mailto:chenbo.xia@intel.com] 
>Sent: Wednesday, 12 August, 2020 17:31
>To: Vipul Ashri <vipul.ashri@oracle.com>; dev@dpdk.org
>Cc: Edwin Leung <edwin.leung@oracle.com>
>Subject: RE: [PATCH v2] Fixes: 57f90f894588("net/virtio: reuse packed ring functions")
>
>Hi Vipul,
>
>> -----Original Message-----
>> From: Vipul Ashri <vipul.ashri@oracle.com>
>> Sent: Wednesday, August 12, 2020 5:23 PM
>> To: dev@dpdk.org
>> Cc: Xia, Chenbo <chenbo.xia@intel.com>; vipul.ashri@oracle.com; 
>> edwin.leung@oracle.com
>> Subject: [PATCH v2] Fixes: 57f90f894588("net/virtio: reuse packed ring
>> functions")
>> 
>> Problem - Standard Tx packets are not going out and found broken  due 
>> to cleanup malfunctioning whereever below mentioned macro is  used.
>> 
>> RootCause - Here inside Macro 'ASSIGN_UNLESS_EQUAL(var, val)'
>>  assignment to 'var' argument passed is always failing as assignment  
>> done using 'var_' having local scope only.
>> 
>> Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com>
>
>I understand now. Your patch makes sense. But your commit title/msg is still wrong. An example commit message should be (you could use this):
>
>net/virtio: fix wrong variable assignment in helper macro
>
>Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always failing as assignment done using var_ having local scope only. This leads to TX packets not going out and found broken due to cleanup malfunctioning. This patch fixes the wrong variable assignment.
>
>Fixes: 57f90f894588("net/virtio: reuse packed ring functions")
>Cc: stable@dpdk.org
>
>Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com>
>
>> ---
>>  drivers/net/virtio/virtqueue.h | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>> 
>> diff --git a/drivers/net/virtio/virtqueue.h 
>> b/drivers/net/virtio/virtqueue.h index 105a9c00c..20c95471e 100644
>> --- a/drivers/net/virtio/virtqueue.h
>> +++ b/drivers/net/virtio/virtqueue.h
>> @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq)
>> 
>>  /* avoid write operation when necessary, to lessen cache issues */
>>  #define ASSIGN_UNLESS_EQUAL(var, val) do {	\
>> -	typeof(var) var_ = (var);		\
>> -	typeof(val) val_ = (val);		\
>> -	if ((var_) != (val_))			\
>> -		(var_) = (val_);		\
>> +	if ((var) != (val))			\
>> +		(var) = (val);			\
>>  } while (0)
>> 
>>  #define virtqueue_clear_net_hdr(hdr) do {		\
>> --
>> 2.28.0.windows.1
diff mbox series

Patch

diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 105a9c00c..20c95471e 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -607,10 +607,8 @@  virtqueue_notify(struct virtqueue *vq)
 
 /* avoid write operation when necessary, to lessen cache issues */
 #define ASSIGN_UNLESS_EQUAL(var, val) do {	\
-	typeof(var) var_ = (var);		\
-	typeof(val) val_ = (val);		\
-	if ((var_) != (val_))			\
-		(var_) = (val_);		\
+	if ((var) != (val))			\
+		(var) = (val);			\
 } while (0)
 
 #define virtqueue_clear_net_hdr(hdr) do {		\