diff mbox series

common/mlx5: fix MAC addresses flush

Message ID 1596032940-20138-1-git-send-email-shirik@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series common/mlx5: fix MAC addresses flush |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Shiri Kuzin July 29, 2020, 2:29 p.m. UTC 
  mlx5_nl_mac_addr_flush should flush all allocated MAC
addresses.

The MAC addresses array size should be of size
MLX5_MAX_MAC_ADDRESSES, but currently we return without
flushing the addresses if size is MLX5_MAX_MAC_ADDRESSES.

This was fixed by not allowing an array larger than
MLX5_MAX_MAC_ADDRESSES.

Fixes: e9a8ac59b6e2 ("common/mlx5: fix MAC addresses assert")
Cc: stable@dpdk.org

Signed-off-by: Shiri Kuzin <shirik@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
 drivers/common/mlx5/linux/mlx5_nl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Raslan Darawsheh July 29, 2020, 3:12 p.m. UTC | #1 
Hi,

> -----Original Message-----
> From: Shiri Kuzin <shirik@mellanox.com>
> Sent: Wednesday, July 29, 2020 5:29 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; stable@dpdk.org
> Subject: [PATCH] common/mlx5: fix MAC addresses flush
> 
> mlx5_nl_mac_addr_flush should flush all allocated MAC
> addresses.
> 
> The MAC addresses array size should be of size
> MLX5_MAX_MAC_ADDRESSES, but currently we return without
> flushing the addresses if size is MLX5_MAX_MAC_ADDRESSES.
> 
> This was fixed by not allowing an array larger than
> MLX5_MAX_MAC_ADDRESSES.
> 
> Fixes: e9a8ac59b6e2 ("common/mlx5: fix MAC addresses assert")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shiri Kuzin <shirik@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
>  drivers/common/mlx5/linux/mlx5_nl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/common/mlx5/linux/mlx5_nl.c
> b/drivers/common/mlx5/linux/mlx5_nl.c
> index 8ab7f6b..0ecd9c7 100644
> --- a/drivers/common/mlx5/linux/mlx5_nl.c
> +++ b/drivers/common/mlx5/linux/mlx5_nl.c
> @@ -790,7 +790,7 @@ struct mlx5_nl_ifindex_data {
>  {
>  	int i;
> 
> -	if (n <= 0 || n >= MLX5_MAX_MAC_ADDRESSES)
> +	if (n <= 0 || n > MLX5_MAX_MAC_ADDRESSES)
>  		return;
> 
>  	for (i = n - 1; i >= 0; --i) {
> --
> 1.8.3.1


Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c
index 8ab7f6b..0ecd9c7 100644
--- a/drivers/common/mlx5/linux/mlx5_nl.c
+++ b/drivers/common/mlx5/linux/mlx5_nl.c
@@ -790,7 +790,7 @@  struct mlx5_nl_ifindex_data {
 {
 	int i;
 
-	if (n <= 0 || n >= MLX5_MAX_MAC_ADDRESSES)
+	if (n <= 0 || n > MLX5_MAX_MAC_ADDRESSES)
 		return;
 
 	for (i = n - 1; i >= 0; --i) {