From patchwork Fri Jul 24 05:32:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 74731 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3829A0518; Fri, 24 Jul 2020 07:36:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8FEA81C136; Fri, 24 Jul 2020 07:34:46 +0200 (CEST) Received: from mail-vk1-f226.google.com (mail-vk1-f226.google.com [209.85.221.226]) by dpdk.org (Postfix) with ESMTP id 01DBA1C1CB for ; Fri, 24 Jul 2020 07:34:03 +0200 (CEST) Received: by mail-vk1-f226.google.com with SMTP id b6so450020vkb.6 for ; Thu, 23 Jul 2020 22:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N1XtpJDfxLDEuuV4CN9/AmoMOYj2FDHNRu0BbYJOM+4=; b=U9b/xII4O9E7VKLKoNbv0RtPZt0mdy4uSRFleUMvtmZPrrO959K76TnwOhKpx4cwPf gVvCmVP+0pTyJC03+x0/Yx8b7K1KJcDOndrGgp57EB2fU+T6KEOnKA1zv3xohOvx02gL Qt1vzP/QYWdaBL5Evmy4XrXw8ya2GG8h3bEpI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N1XtpJDfxLDEuuV4CN9/AmoMOYj2FDHNRu0BbYJOM+4=; b=OzjZEHSbSIeCMyZjl9pbxZ0OGRRdzAjxAzrRIuu5oLtTwJc02xKpZgXVeVLbZVKYtW Oh1erX2X4diWIOVupac2PaMUCcj4zUbo3+gwplVzlg1Vi3HPbj0wJovicK6yZR0qjr7p P0bVkO49anXqhQu5etJtEzKCLk9jaVCji5DNTBYKT9ewaUH7cIXv98mkonsuMaebw0GB 9TXzQDD8B6+mhAXnSB0JsnnymSLZONDHY9QkLnkxbimXfJ4Wgg+0RDuujwNUvhM0heAB UNkgeVimKwi02NHsTrJzIWHaOA2CgUulDxtfdmTaZ0au4A0biEX+SpPfUfUKQ5rVK6WR ZjJQ== X-Gm-Message-State: AOAM533DdLnBX+fDAaMA/6ISRnWq2HEolvHer3y6MrZCH/mfw+Q6Y/oR twiBlMbvUYqW0h0jiwRzFaiomWEQGefPqYC2yjZ1drXpDsGGRoqUpybkxKiHr5wIzaBlrAdzZfK Bef4OXlm74s+6FW4K1UKIXY7ykXm3ytccuGYmH8gr20BnOCFXTWRWdohzQPVcgHGjN2g7gtYIcv rcHQ== X-Google-Smtp-Source: ABdhPJzpzYW4Nm3SgUppDHfqyHohCtfXbpuX4iTCN1W0kQb2QtidFQZYGyF9K0eBu0O/4HKwkeTjkhHXFI/I X-Received: by 2002:a1f:a883:: with SMTP id r125mr6558128vke.29.1595568842367; Thu, 23 Jul 2020 22:34:02 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp-relay.gmail.com with ESMTPS id h17sm592840vsk.0.2020.07.23.22.34.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Jul 2020 22:34:02 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Thu, 23 Jul 2020 22:32:34 -0700 Message-Id: <20200724053235.71069-22-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200724053235.71069-1-ajit.khaparde@broadcom.com> References: <20200723115639.22357-1-somnath.kotur@broadcom.com> <20200724053235.71069-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 21/22] net/bnxt: fix if condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The if condition in bnxt_restore_mac_filters needs to check for the result of logical AND. But it was not doing it resulting in an incorrect check. Fixes: b02f1573cd07 ("net/bnxt: restore MAC filters during reset recovery") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index dfc4b4190..510a0d9e0 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -4372,7 +4372,7 @@ static int bnxt_restore_mac_filters(struct bnxt *bp) uint16_t i; int rc; - if (BNXT_VF(bp) & !BNXT_VF_IS_TRUSTED(bp)) + if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) return 0; rc = bnxt_dev_info_get_op(dev, &dev_info);