From patchwork Thu Jul 23 20:09:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Parav Pandit X-Patchwork-Id: 74694 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BAE6A0518; Thu, 23 Jul 2020 22:10:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4EA551C042; Thu, 23 Jul 2020 22:09:44 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130049.outbound.protection.outlook.com [40.107.13.49]) by dpdk.org (Postfix) with ESMTP id B8C5E1C02A for ; Thu, 23 Jul 2020 22:09:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fr3UlYOkK/HV011VdImqJpE0DuyLiUS73pgRLI5Zp6ZKTod/ZntIetsCoNxSI9gP9dNP876Ev8kbT+btLhsH0/85jk+zxpLNm5Up5yLMzp8gmeOVuLM2EkwppLV+xKRpnDnQ3GrApMEVmL9A0PrORFTYercmyojqhTXB9R3ZxzmrHLp+YRBRJF+LsW+2+eqxDHKfTiMNrTLjtza3EVbPvq6Adj+6b+91ZJzuxdCanBY41lb3RSY0KQgBOR5+g1bT+oZLb4uG31j6B6vrHJbVKU6HVh2JpP7sUPQErYYN8WWJGlFapPSjWgwOL2DnmYBuyVxH48NNgGHYhbrcHEgHlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=01RK3otJaGVDPbIDqEEVdRcMZyh2Bq2eBK9blqoZY4s=; b=RAlqTcnQGE77vv9wGkzvmTE5uQNozQYHj9kZFLt04rREQjOAfCwWwwechswSJnDv4Ps6cN+29qFt5VuFnx/hlyP0JzBbn5RAxu5omNjeB6KfOtUTt87cH7epYZ8GRm0UGmf+SKMASM+0tVHk7SOT7zKe3mRA4ldJsVRMTrzt1+kf4JI7f/m/QoI5TRkUXGrHsFZ8YkDDocv02QENGMm+yjfysH5v8AL2WzSTTay64g2MuUmHd8/JyQBkfrz0LLZIrrzbqwMSfxQWZoK/KF5SKhl0GitUoUHGia4QzOMGWQoCik/9K8kKGw1b1DaZ0Crsz2vcYGX9LD229OXHorb0HQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=01RK3otJaGVDPbIDqEEVdRcMZyh2Bq2eBK9blqoZY4s=; b=GSzyWtXN7POFYBAjT9dwlZlQ6rMFuuRXriqw+qJdGVn54r88vKYeg4FaYvaXXhTB3Picgc0Gt9hgsuYGCNRDMuoB3DNCHI9c27Va3bfmXryoF3V9DERTzkxG44x0UXaUOYEClGEnP/PsqSD0LMvIQWFKeWmM4UKivYaRElsnvwA= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from DB7PR05MB4876.eurprd05.prod.outlook.com (2603:10a6:10:1d::32) by DB7PR05MB5558.eurprd05.prod.outlook.com (2603:10a6:10:5c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Thu, 23 Jul 2020 20:09:37 +0000 Received: from DB7PR05MB4876.eurprd05.prod.outlook.com ([fe80::8cb3:93cb:c3ef:4293]) by DB7PR05MB4876.eurprd05.prod.outlook.com ([fe80::8cb3:93cb:c3ef:4293%5]) with mapi id 15.20.3216.022; Thu, 23 Jul 2020 20:09:37 +0000 From: Parav Pandit To: dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net Cc: rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com, joyce.kong@arm.com, Parav Pandit Date: Thu, 23 Jul 2020 23:09:04 +0300 Message-Id: <20200723200910.376581-5-parav@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200723200910.376581-1-parav@mellanox.com> References: <20200610171728.89-2-parav@mellanox.com> <20200723200910.376581-1-parav@mellanox.com> X-ClientProxiedBy: DM6PR03CA0009.namprd03.prod.outlook.com (2603:10b6:5:40::22) To DB7PR05MB4876.eurprd05.prod.outlook.com (2603:10a6:10:1d::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by DM6PR03CA0009.namprd03.prod.outlook.com (2603:10b6:5:40::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.21 via Frontend Transport; Thu, 23 Jul 2020 20:09:35 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [208.176.44.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: bbd3984b-dd38-42c6-de39-08d82f4452d4 X-MS-TrafficTypeDiagnostic: DB7PR05MB5558: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:327; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b31N4APWGiTjPXelI4WK4prWC2poVSOGc7xyZP4GGQnOkwhst/jM1E5alKZ85T1H2VN06oicKFjXkGnB0yHBwV387yY6DRBMJnGbzsm2KB2I6bZvC87P8GGVXLqxOhdKEuKnBH277Pcu7Vwm+vXuRu17wrlvv6HxF/Wmg/U0A+JltfCfSnYc6Zg11WDM0VU+7rJGO7Nwqg7thbno5+ohwC3v+pi66gNpSs2fnAPqQ5lmrCZh1irEyw0mIn3HM/wJLsar6LwO3yMOIdBXd/Hh/tQgEq361W32MxwOBwPE26y+EE/gLGaTBjCC7P5yV7f+ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR05MB4876.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(346002)(366004)(396003)(136003)(39860400002)(6506007)(8676002)(8936002)(26005)(52116002)(2906002)(4326008)(478600001)(66946007)(66476007)(66556008)(83380400001)(36756003)(5660300002)(2616005)(6486002)(86362001)(956004)(1076003)(6512007)(6666004)(107886003)(186003)(16526019)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: /93eQg+W5TlNLgyTSOTtgdpdw13YPxOIOux+Bu35r3SzZu0ByMgaAufc27BGnWzY6p6YZo+marUVdLoLBXKr5TWWbnOzxmwn1CCmNvQGeKdwkf8WwODdsx4Y2d6USsM57pPr6uPjMhC4JbgNo+dCElW16dcJRSA2ZXYxsOdMO9Tj66N2II8PTS6p79fQbIxR3ShO7IQoRMzUo0yebnUKoEOzrJxKyhmopFdQQW6mU9QBt0Q2EYBW/yy69oBpP9E1HhADNCsIibwONMptE1ZsQy7GV5S4++PtW7IuOSeBswVCcYy6VoIC6nOFNjwujq7U7pqGwBAZ7ydhv3wXWMok0xN44W3GNbDZuvfukwAFIfDs4IsB0H8rYLgW0PUeETwZttBSv2kg8U6Ava1r6u+KBy3vlyvVbOTna9drDVVbMTQCqDJP53kMhEfLXtxl1g11NFKSUe5fKdk0rkDo4LXjtPNfrTVnc9J0kAVRZrS6t0kjp0RCKKkjWnIiANfkb3kd X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbd3984b-dd38-42c6-de39-08d82f4452d4 X-MS-Exchange-CrossTenant-AuthSource: DB7PR05MB4876.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2020 20:09:36.8328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GrOXEQWQhLKsDA0NTs/7yIdtccn9P9H+3WjjVd/YKXJsQzGwj8zzdrJ8zM+YCEFQAFSdBXScvT3m5FWj5FneIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5558 Subject: [dpdk-dev] [PATCH v8 04/10] common/mlx5: fix void parameters in glue wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Following two errors are reported when compiled with gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5). drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] Fix them by adding void data type in empty argument list. Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch") Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue") Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_glue.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_glue.h b/drivers/common/mlx5/linux/mlx5_glue.h index c4f9b006a..734ace2a3 100644 --- a/drivers/common/mlx5/linux/mlx5_glue.h +++ b/drivers/common/mlx5/linux/mlx5_glue.h @@ -185,11 +185,11 @@ struct mlx5_glue { void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl); void *(*dr_create_flow_action_dest_port)(void *domain, uint32_t port); - void *(*dr_create_flow_action_drop)(); + void *(*dr_create_flow_action_drop)(void); void *(*dr_create_flow_action_push_vlan) (struct mlx5dv_dr_domain *domain, rte_be32_t vlan_tag); - void *(*dr_create_flow_action_pop_vlan)(); + void *(*dr_create_flow_action_pop_vlan)(void); void *(*dr_create_flow_tbl)(void *domain, uint32_t level); int (*dr_destroy_flow_tbl)(void *tbl); void *(*dr_create_domain)(struct ibv_context *ctx,