From patchwork Thu Jul 23 11:06:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raslan Darawsheh X-Patchwork-Id: 74639 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44CF3A0521; Thu, 23 Jul 2020 13:06:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D27BA1BE9A; Thu, 23 Jul 2020 13:06:28 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2051.outbound.protection.outlook.com [40.107.22.51]) by dpdk.org (Postfix) with ESMTP id 78E9F1BE90; Thu, 23 Jul 2020 13:06:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zrlplgc5VRL1mYFXqQDIoRjJGj4OCnbjvxz8gGDN7LtabXve8nkvFAm5+wEFgaBVojsynaPPbhH5RMHpWfsH8S3NdYFih3LoO7Yp732uiJwkBnZLhOVVeSLmW1jRmQsqG6vF2TrYoPH52jy2jBvZGm5uYp8jrnQobb5wisppObAYapK7mDZwEQ/08nwsARrs9mG30nj79aAbZKV/DNU2VCkzM3CfCz9K8prFgac5jAA7j+cGAmHODGX8Xe5y754OOL2+wQFSYbboKMsbtMx81ItC6P/KD/cmjZFHwSzyE3q1237hVhZZ+XvSZfMf5MlbknPZWgNjblD/61TtP8QWGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I/Mh2OOC1iqcWkjEIy06uXqWavSaXyPxDdZmD/wQipE=; b=lygHKlg9HQ2EeKmrQZ9J5s5UO+FhZfABER7+qvYtFERDmQSvw8Ehi50/rO/vLQMUWLZTmpwIdxTiNZo4LwyHsXONrHga0ricC2TTzg+2vE/ExWclS9r85eivt3OP+trPgQLR4oolSDti5h3ClhpZ5hO5SE0t0FkrsoaPN0UxGnT3jHDyFKggtgMJ42feBm0s+yufjxG/p8DGwZtNrKGGC4mu7Yyo3plMTJKVOENkAyeHcYx1TRblTjhYWe18Q+PyyM+vohnUn81KxLOSjHlUTom+5j96kjkrmK0O72yoomtwqj1XAvdl8oNao5C9TUGYbSaqwnPFL4qZ1PTST/bYZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I/Mh2OOC1iqcWkjEIy06uXqWavSaXyPxDdZmD/wQipE=; b=Y+CKohlC1i3y5wMAe/zKpQKvT5+E29VauINNK4KzUl0dlm6oIKHKFy4bzoFhkap2CLDcartpff8Rd3va4TexU5ZSInpOx2hFz9RvRv3cqCv4K8tfUgSJpw5wZwrZn6OkrTE83Wq0jdMKoeftTfDurWBtxSxmxZ+2HaPTLxHK5v8= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) by AM4PR0501MB2721.eurprd05.prod.outlook.com (2603:10a6:200:5d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Thu, 23 Jul 2020 11:06:26 +0000 Received: from AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Thu, 23 Jul 2020 11:06:26 +0000 From: Raslan Darawsheh To: dev@dpdk.org Cc: ferruh.yigit@intel.com, stable@dpdk.org, Viacheslav Ovsiienko Date: Thu, 23 Jul 2020 14:06:13 +0300 Message-Id: <20200723110613.8363-1-rasland@mellanox.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200722090755.26103-1-rasland@mellanox.com> References: <20200722090755.26103-1-rasland@mellanox.com> X-ClientProxiedBy: ZR0P278CA0053.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::22) To AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mellanox.com (84.242.49.134) by ZR0P278CA0053.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3216.23 via Frontend Transport; Thu, 23 Jul 2020 11:06:25 +0000 X-Mailer: git-send-email 2.27.0 X-Originating-IP: [84.242.49.134] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 74fd3955-91a1-4839-33b5-08d82ef87152 X-MS-TrafficTypeDiagnostic: AM4PR0501MB2721: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1923; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wox9vtBFZiCWQr1mR1C8/QeEALzsBCmmUpFP7hqC6zOBz64+x9Lj8A6XJylNIwJAm7e58aHaECrOiTNiSPWSbqmNOQJHfoG+QHy16A9Hos32RTSiGyx2/SDni31tiswwy3WxpPsocM6T70fagrT4TuhnGZlrqiSuxgtJGJSO9ADJpRwWFGztv4SsWdrO5HuwRLhw/7bBQ+BP4Jyu827SFXqJ/J0CXQ5ehAMuZ7nGPp8TUnpjfRIpOBlKh02ZHeKDpl3RlEB9lwOJBYQzIe6kcdAg/WYHsTZVvEftnv9DvRxPsRb9cq6meF2eeD+itzcaBSFZ+Miu4aetis+JzZvQ3w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(346002)(396003)(376002)(136003)(39860400002)(66946007)(66556008)(66476007)(107886003)(55016002)(4326008)(52116002)(7696005)(36756003)(6666004)(8886007)(5660300002)(186003)(316002)(2906002)(478600001)(16526019)(6916009)(26005)(1076003)(8676002)(83380400001)(86362001)(8936002)(956004)(2616005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: rR2QS60zeQrSOuAOs/J2zopVb9yC6owXPEYDogh1EnumhnaPlh8EDd238zCsDe7e/BQbU6kV7nMxywDNL7Wi0JN4k8o+nYNVY/BiCk+2bx4nEl3EM8i985aKYe0Kn/SxhiZzsm1bam9g+S6GX1YkdqZRZueGpH4pR0TZDpSU0WTlgtXLoy+djUbB7SD2htZDLJpOt1MI5NzB1+GGHZPH+nnMaYqVMv2nEhMf/pQejsbhSqrd6Nxp5MlHiDsAWDN2I8NSO1RvWhGHxrhclmNWYNVyCvi3mHXcVQI6IEAaaCQgnvuvmyaDPo9TQTHmkyvMsviouooD6Ubw8el1u3OnjUtJA60hbqme2JqTiim+FJr+cy5z5t72wAswm3ZTXL6UzJsCsRhRz0chk1tg6K1A3zvg6cU+oU7yo7bE/ytiOt4n2hSuj12haJ/vv5dxj7XwPIy0j5sIlaz0ayQWhM+om7HxvglswBbnKBkYMPCx0XrTZmdyO/PuivFveBnar5/7 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74fd3955-91a1-4839-33b5-08d82ef87152 X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB6707.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2020 11:06:26.3682 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SFvbtWjkSjMk2bPakS5T1jDLMNNt8sAUy96HIs3gRFttbhcaVoSJZWTKW3GrmoeEE4CadzLeZiO0CX8kRDutmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2721 Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix VF MAC address set over Bluefield X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When trying to set MAC address of an ethethet device and if it was a representor, PMD sets the MAC over the corresponding VF instead. For the case of HPF (Host PF representor on BluueField), PMD shouldn't attempt to set it, since it doesn't have any corresponding VF and fails. This will fix the issue by setting the MAC on the dev directly. Fixes: 0d1d73170820 ("net/mlx5: set VF MAC address from host") Cc: stable@dpdk.org Signed-off-by: Raslan Darawsheh Acked-by: Viacheslav Ovsiienko --- v2: fix the use of representor bit to use the representor id instead --- drivers/net/mlx5/mlx5_mac.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c index 2d808d629..88c52b29f 100644 --- a/drivers/net/mlx5/mlx5_mac.c +++ b/drivers/net/mlx5/mlx5_mac.c @@ -157,8 +157,11 @@ mlx5_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr) uint16_t port_id; struct mlx5_priv *priv = dev->data->dev_private; - /* Configuring the VF instead of its representor. */ - if (priv->representor) { + /* + * Configuring the VF instead of its representor, + * need to skip the special case of HPF on Bluefield. + */ + if (priv->representor && priv->representor_id >= 0) { DRV_LOG(DEBUG, "VF represented by port %u setting primary MAC address", dev->data->port_id); RTE_ETH_FOREACH_DEV_SIBLING(port_id, dev->data->port_id) {