[5/8] net/i40e/base: check return value of DNL admin command
diff mbox series

Message ID 20200721074000.30449-6-guinanx.sun@intel.com
State Superseded, archived
Delegated to: Qi Zhang
Headers show
Series
  • update i40e base code
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Guinan Sun July 21, 2020, 7:39 a.m. UTC
Check return value of running DNL admin command.

Signed-off-by: Adam Ludkiewicz <adam.ludkiewicz@intel.com>
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
 drivers/net/i40e/base/i40e_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jeff Guo July 27, 2020, 4:07 a.m. UTC | #1
hi, guinan

On 7/21/2020 3:39 PM, Guinan Sun wrote:
> Check return value of running DNL admin command.


What is "DNL", I am not sure i know the reason it appear here, could you 
double check it?


>
> Signed-off-by: Adam Ludkiewicz <adam.ludkiewicz@intel.com>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
>   drivers/net/i40e/base/i40e_common.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c
> index 46a0b7881..85c22849e 100644
> --- a/drivers/net/i40e/base/i40e_common.c
> +++ b/drivers/net/i40e/base/i40e_common.c
> @@ -7097,7 +7097,7 @@ enum i40e_status_code i40e_get_lpi_counters(struct i40e_hw *hw,
>   				I40E_AQ_RUN_PHY_ACT_DNL_OPCODE_GET_EEE_STAT,
>   				&cmd_status, tx_counter, rx_counter, NULL);
>   
> -		if (cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)
> +		if (!retval && cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)
>   			retval = I40E_ERR_ADMIN_QUEUE_ERROR;
>   
>   		return retval;
Guinan Sun July 27, 2020, 4:53 a.m. UTC | #2
Hi Jeff

> -----Original Message-----
> From: Guo, Jia
> Sent: Monday, July 27, 2020 12:08 PM
> To: Sun, GuinanX <guinanx.sun@intel.com>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Ludkiewicz, Adam
> <adam.ludkiewicz@intel.com>
> Subject: Re: [PATCH 5/8] net/i40e/base: check return value of DNL admin
> command
> 
> hi, guinan
> 
> On 7/21/2020 3:39 PM, Guinan Sun wrote:
> > Check return value of running DNL admin command.
> 
> 
> What is "DNL", I am not sure i know the reason it appear here, could you
> double check it?
> 

Regarding what DNL stands for, I haven't found it in the code and datasheet.
It can be seen from the code change that the return value check operation of i40e_aq_run_phy_activity has been added.
The description of this function is RUN DNL admin command.
So tile and commit log have made such changes.

> 
> >
> > Signed-off-by: Adam Ludkiewicz <adam.ludkiewicz@intel.com>
> > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> > ---
> >   drivers/net/i40e/base/i40e_common.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/base/i40e_common.c
> b/drivers/net/i40e/base/i40e_common.c
> > index 46a0b7881..85c22849e 100644
> > --- a/drivers/net/i40e/base/i40e_common.c
> > +++ b/drivers/net/i40e/base/i40e_common.c
> > @@ -7097,7 +7097,7 @@ enum i40e_status_code
> i40e_get_lpi_counters(struct i40e_hw *hw,
> >
> 	I40E_AQ_RUN_PHY_ACT_DNL_OPCODE_GET_EEE_STAT,
> >   				&cmd_status, tx_counter, rx_counter, NULL);
> >
> > -		if (cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)
> > +		if (!retval && cmd_status !=
> I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)
> >   			retval = I40E_ERR_ADMIN_QUEUE_ERROR;
> >
> >   		return retval;
Guinan Sun July 27, 2020, 5:19 a.m. UTC | #3
Hi, Jeff

> -----Original Message-----
> From: Sun, GuinanX
> Sent: Monday, July 27, 2020 12:54 PM
> To: Guo, Jia <jia.guo@intel.com>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Ludkiewicz, Adam
> <adam.ludkiewicz@intel.com>
> Subject: RE: [PATCH 5/8] net/i40e/base: check return value of DNL admin
> command
> 
> Hi Jeff
> 
> > -----Original Message-----
> > From: Guo, Jia
> > Sent: Monday, July 27, 2020 12:08 PM
> > To: Sun, GuinanX <guinanx.sun@intel.com>; dev@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; Ludkiewicz, Adam
> > <adam.ludkiewicz@intel.com>
> > Subject: Re: [PATCH 5/8] net/i40e/base: check return value of DNL
> > admin command
> >
> > hi, guinan
> >
> > On 7/21/2020 3:39 PM, Guinan Sun wrote:
> > > Check return value of running DNL admin command.
> >
> >
> > What is "DNL", I am not sure i know the reason it appear here, could
> > you double check it?
> >
> 
> Regarding what DNL stands for, I haven't found it in the code and datasheet.
> It can be seen from the code change that the return value check operation of
> i40e_aq_run_phy_activity has been added.
> The description of this function is RUN DNL admin command.
> So tile and commit log have made such changes.

Sorry, I might have misunderstood it just now.
I will double check for it and patch V2 will modify it.

> 
> >
> > >
> > > Signed-off-by: Adam Ludkiewicz <adam.ludkiewicz@intel.com>
> > > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> > > ---
> > >   drivers/net/i40e/base/i40e_common.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/i40e/base/i40e_common.c
> > b/drivers/net/i40e/base/i40e_common.c
> > > index 46a0b7881..85c22849e 100644
> > > --- a/drivers/net/i40e/base/i40e_common.c
> > > +++ b/drivers/net/i40e/base/i40e_common.c
> > > @@ -7097,7 +7097,7 @@ enum i40e_status_code
> > i40e_get_lpi_counters(struct i40e_hw *hw,
> > >
> > 	I40E_AQ_RUN_PHY_ACT_DNL_OPCODE_GET_EEE_STAT,
> > >   				&cmd_status, tx_counter, rx_counter, NULL);
> > >
> > > -		if (cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)
> > > +		if (!retval && cmd_status !=
> > I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)
> > >   			retval = I40E_ERR_ADMIN_QUEUE_ERROR;
> > >
> > >   		return retval;

Patch
diff mbox series

diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c
index 46a0b7881..85c22849e 100644
--- a/drivers/net/i40e/base/i40e_common.c
+++ b/drivers/net/i40e/base/i40e_common.c
@@ -7097,7 +7097,7 @@  enum i40e_status_code i40e_get_lpi_counters(struct i40e_hw *hw,
 				I40E_AQ_RUN_PHY_ACT_DNL_OPCODE_GET_EEE_STAT,
 				&cmd_status, tx_counter, rx_counter, NULL);
 
-		if (cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)
+		if (!retval && cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)
 			retval = I40E_ERR_ADMIN_QUEUE_ERROR;
 
 		return retval;