crypto/octeontx2: fix structure alignment
diff mbox series

Message ID 20200721041618.29603-1-ktejasree@marvell.com
State Accepted, archived
Delegated to: akhil goyal
Headers show
Series
  • crypto/octeontx2: fix structure alignment
Related show

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Tejasree Kondoj July 21, 2020, 4:16 a.m. UTC
The structure cpt_request_info needs only 8 byte alignment.
This patch replaces __rte_cache_aligned of cpt_request_info
with __rte_aligned(8) and removes __rte_aligned(8) in
cpt_meta_info structure.

Fixes: fab634eb87ca ("crypto/octeontx2: support security session data path")

Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
---
 drivers/common/cpt/cpt_common.h           | 2 +-
 drivers/crypto/octeontx2/otx2_cryptodev.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Anoob Joseph July 21, 2020, 7:09 a.m. UTC | #1
> 
> The structure cpt_request_info needs only 8 byte alignment.
> This patch replaces __rte_cache_aligned of cpt_request_info with
> __rte_aligned(8) and removes __rte_aligned(8) in cpt_meta_info structure.
> 
> Fixes: fab634eb87ca ("crypto/octeontx2: support security session data path")
> 
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>

Acked-by: Anoob Joseph <anoobj@marvell.com>

Thanks Ferruh for pointing this out.
Akhil Goyal July 26, 2020, 7:09 p.m. UTC | #2
> >
> > The structure cpt_request_info needs only 8 byte alignment.
> > This patch replaces __rte_cache_aligned of cpt_request_info with
> > __rte_aligned(8) and removes __rte_aligned(8) in cpt_meta_info structure.
> >
> > Fixes: fab634eb87ca ("crypto/octeontx2: support security session data path")
> >
> > Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> 
> Acked-by: Anoob Joseph <anoobj@marvell.com>
> 
> Thanks Ferruh for pointing this out.

Applied to dpdk-next-crypto

Thanks.

Patch
diff mbox series

diff --git a/drivers/common/cpt/cpt_common.h b/drivers/common/cpt/cpt_common.h
index 56bfea4953..0141b2aed5 100644
--- a/drivers/common/cpt/cpt_common.h
+++ b/drivers/common/cpt/cpt_common.h
@@ -76,6 +76,6 @@  struct cpt_request_info {
 	/** Control path fields */
 	uint64_t time_out;
 	uint8_t extra_time;
-} __rte_cache_aligned;
+} __rte_aligned(8);
 
 #endif /* _CPT_COMMON_H_ */
diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.h b/drivers/crypto/octeontx2/otx2_cryptodev.h
index f329741b38..a00f3d696e 100644
--- a/drivers/crypto/octeontx2/otx2_cryptodev.h
+++ b/drivers/crypto/octeontx2/otx2_cryptodev.h
@@ -38,7 +38,7 @@  struct cpt_meta_info {
 	uint64_t deq_op_info[4];
 	uint64_t comp_code_sz;
 	union cpt_res_s cpt_res __rte_aligned(16);
-	struct cpt_request_info cpt_req __rte_aligned(8);
+	struct cpt_request_info cpt_req;
 };
 
 #define CPT_LOGTYPE otx2_cpt_logtype