[DPDK,v2] net/i40e: add VLAN filter feature to capability
diff mbox series

Message ID 20200721024528.1520-1-zhihongx.peng@intel.com
State Accepted, archived
Delegated to: Qi Zhang
Headers show
Series
  • [DPDK,v2] net/i40e: add VLAN filter feature to capability
Related show

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Peng, ZhihongX July 21, 2020, 2:45 a.m. UTC
From: Peng Zhihong <zhihongx.peng@intel.com>

The rte_eth_dev_set_vlan_offload function will check vlan rx offload
capability, the i40e vf has vlan filter feature but
DEV_RX_OFFLOAD_VLAN_FILTER is not set into the capability, that will
cause setting fail. So need to add this capability in
i40e_vf_representor_dev_infos_get function.

Fixes: e0cb96204b71 (net/i40e: add support for representor ports)
Cc: stable@dpdk.org

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 drivers/net/i40e/i40e_vf_representor.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jeff Guo July 21, 2020, 3:11 a.m. UTC | #1
Acked-by: Jeff Guo <jia.guo@intel.com>

On 7/21/2020 10:45 AM, zhihongx.peng@intel.com wrote:
> From: Peng Zhihong <zhihongx.peng@intel.com>
>
> The rte_eth_dev_set_vlan_offload function will check vlan rx offload
> capability, the i40e vf has vlan filter feature but
> DEV_RX_OFFLOAD_VLAN_FILTER is not set into the capability, that will
> cause setting fail. So need to add this capability in
> i40e_vf_representor_dev_infos_get function.
>
> Fixes: e0cb96204b71 (net/i40e: add support for representor ports)
> Cc: stable@dpdk.org
>
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>   drivers/net/i40e/i40e_vf_representor.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c
> index b07b35c03..083bc1a5f 100644
> --- a/drivers/net/i40e/i40e_vf_representor.c
> +++ b/drivers/net/i40e/i40e_vf_representor.c
> @@ -46,7 +46,8 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,
>   		DEV_RX_OFFLOAD_QINQ_STRIP |
>   		DEV_RX_OFFLOAD_IPV4_CKSUM |
>   		DEV_RX_OFFLOAD_UDP_CKSUM |
> -		DEV_RX_OFFLOAD_TCP_CKSUM;
> +		DEV_RX_OFFLOAD_TCP_CKSUM |
> +		DEV_RX_OFFLOAD_VLAN_FILTER;
>   	dev_info->tx_offload_capa =
>   		DEV_TX_OFFLOAD_MULTI_SEGS  |
>   		DEV_TX_OFFLOAD_VLAN_INSERT |
Zhang, Qi Z July 21, 2020, 5:01 a.m. UTC | #2
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Jeff Guo
> Sent: Tuesday, July 21, 2020 11:12 AM
> To: Peng, ZhihongX <zhihongx.peng@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [DPDK v2] net/i40e: add VLAN filter feature to capability
> 
> Acked-by: Jeff Guo <jia.guo@intel.com>
> 
> On 7/21/2020 10:45 AM, zhihongx.peng@intel.com wrote:
> > From: Peng Zhihong <zhihongx.peng@intel.com>
> >
> > The rte_eth_dev_set_vlan_offload function will check vlan rx offload
> > capability, the i40e vf has vlan filter feature but
> > DEV_RX_OFFLOAD_VLAN_FILTER is not set into the capability, that will
> > cause setting fail. So need to add this capability in
> > i40e_vf_representor_dev_infos_get function.
> >
> > Fixes: e0cb96204b71 (net/i40e: add support for representor ports)

Fix line should be (".....")

> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

Patch
diff mbox series

diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c
index b07b35c03..083bc1a5f 100644
--- a/drivers/net/i40e/i40e_vf_representor.c
+++ b/drivers/net/i40e/i40e_vf_representor.c
@@ -46,7 +46,8 @@  i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,
 		DEV_RX_OFFLOAD_QINQ_STRIP |
 		DEV_RX_OFFLOAD_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_UDP_CKSUM |
-		DEV_RX_OFFLOAD_TCP_CKSUM;
+		DEV_RX_OFFLOAD_TCP_CKSUM |
+		DEV_RX_OFFLOAD_VLAN_FILTER;
 	dev_info->tx_offload_capa =
 		DEV_TX_OFFLOAD_MULTI_SEGS  |
 		DEV_TX_OFFLOAD_VLAN_INSERT |