devtools: forbid experimental build flag for non-examples
Checks
Commit Message
-DALLOW_EXPERIMENTAL_API is always set for in-tree compilation since
https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5
Warn people not to copy/paste this flag that was needed before.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/checkpatches.sh | 8 ++++++++
1 file changed, 8 insertions(+)
Comments
16/07/2020 09:26, David Marchand:
> -DALLOW_EXPERIMENTAL_API is always set for in-tree compilation since
> https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5
>
> Warn people not to copy/paste this flag that was needed before.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Applied with small rewording, thanks
@@ -77,6 +77,14 @@ check_forbidden_additions() { # <patch>
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
+ # forbid use of experimental build flag unneeded in non-examples
+ awk -v FOLDERS='app lib drivers' \
+ -v EXPRESSIONS='-DALLOW_EXPERIMENTAL_API allow_experimental_apis' \
+ -v RET_ON_FAIL=1 \
+ -v MESSAGE='Using experimental build flag for in-tree compilation' \
+ -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+ "$1" || res=1
+
# svg figures must be included with wildcard extension
# because of png conversion for pdf docs
awk -v FOLDERS='doc' \