devtools: forbid experimental build flag for non-examples
diff mbox series

Message ID 20200716072648.3076-1-david.marchand@redhat.com
State Accepted
Delegated to: Thomas Monjalon
Headers show
Series
  • devtools: forbid experimental build flag for non-examples
Related show

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

David Marchand July 16, 2020, 7:26 a.m. UTC
-DALLOW_EXPERIMENTAL_API is always set for in-tree compilation since
https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5

Warn people not to copy/paste this flag that was needed before.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 devtools/checkpatches.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Thomas Monjalon July 30, 2020, 9:47 p.m. UTC | #1
16/07/2020 09:26, David Marchand:
> -DALLOW_EXPERIMENTAL_API is always set for in-tree compilation since
> https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5
> 
> Warn people not to copy/paste this flag that was needed before.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Applied with small rewording, thanks

Patch
diff mbox series

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 58021aa5dd..82d57b565b 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -77,6 +77,14 @@  check_forbidden_additions() { # <patch>
 		-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
 		"$1" || res=1
 
+	# forbid use of experimental build flag unneeded in non-examples
+	awk -v FOLDERS='app lib drivers' \
+		-v EXPRESSIONS='-DALLOW_EXPERIMENTAL_API allow_experimental_apis' \
+		-v RET_ON_FAIL=1 \
+		-v MESSAGE='Using experimental build flag for in-tree compilation' \
+		-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+		"$1" || res=1
+
 	# svg figures must be included with wildcard extension
 	# because of png conversion for pdf docs
 	awk -v FOLDERS='doc' \