From patchwork Tue Jul 14 16:01:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sexton, Rory" X-Patchwork-Id: 74013 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0E87A0540; Tue, 14 Jul 2020 18:02:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A6911D168; Tue, 14 Jul 2020 18:02:17 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 374A51D165 for ; Tue, 14 Jul 2020 18:02:16 +0200 (CEST) IronPort-SDR: cDQoaC4UFdxPeufiYAZ4vSbHWm8XE/EkomiqGnjXSMclbTusxC/5DwSfd8yfr5jkaD6fnJ7W2n mQHFnEYAldBQ== X-IronPort-AV: E=McAfee;i="6000,8403,9681"; a="146446384" X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="146446384" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2020 09:02:03 -0700 IronPort-SDR: n9yf2JAVXQ7h4QYPgkU9qktUJFznk50gYKLpPMGmm5CBmYQGpA4w2Yz/tX4OdG4Xx+RBiYKYZd UcaypxEuY0uQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="285799820" Received: from silpixa00399913.ir.intel.com ([10.237.213.189]) by orsmga006.jf.intel.com with ESMTP; 14 Jul 2020 09:02:02 -0700 From: Rory Sexton To: dev@dpdk.org, david.hunt@intel.com Date: Tue, 14 Jul 2020 17:01:59 +0100 Message-Id: <20200714160200.1727417-2-rory.sexton@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714160200.1727417-1-rory.sexton@intel.com> References: <20200714160200.1727417-1-rory.sexton@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [v4 2/3] examples/vm_power_manager: Allowing power managing of idle cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This change is required to allow the branch ratio algorithm to power manage cores with no workload running on them. This is useful both when idle cores don't use C-states and for a number of hyperthreading scenarios. Signed-off-by: Rory Sexton Reviewed-by: David Hunt Acked-by: Reshma pattan --- v4: no changes --- examples/vm_power_manager/oob_monitor_x86.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/vm_power_manager/oob_monitor_x86.c b/examples/vm_power_manager/oob_monitor_x86.c index 3c514475f..a5b1c168c 100644 --- a/examples/vm_power_manager/oob_monitor_x86.c +++ b/examples/vm_power_manager/oob_monitor_x86.c @@ -96,12 +96,12 @@ apply_policy(int core) g_branch_misses = miss_diff; if (hits_diff < (INTERVAL*100)) { - /* Likely no workload running on this core. Skip. */ - return -1.0; + /* Likely no workload running on this core. */ + ratio = 0.0; + } else { + ratio = (float)miss_diff * (float)100 / (float)hits_diff; } - ratio = (float)miss_diff * (float)100 / (float)hits_diff; - /* * Store the last few directions that the ratio indicates * we should take. If there's on 'up', then we scale up