[v3,2/2] event/dpaa2: Add all type queue capability flag

Message ID 20200713114406.4383-2-apeksha.gupta@nxp.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers
Series [v3,1/2] app/test-eventdev: Fix pipeline atq |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK

Commit Message

Apeksha Gupta July 13, 2020, 11:44 a.m. UTC
  Event device capability flag added in event driver,
Event device is capable of enqueuing events of any type to any queue.

Fixes: 8f4a294c23 ("event/dpaa2: apply new capability flags")
Cc: stable@dpdk.org

Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
---
v3:
* Added patch
1. event/dpaa2: Add all type queue capability flag

v2:
* Removed unrequired patches
1. app/test-eventdev: Enhancing perf-queue packet flow
2. app/test-eventdev: Removed unwanted checks
3. event/dpaa2: Add all type queue capability flag
4. app/test-eventdev: Enhancing perf-atq packet flow
5. app/test-eventdev: fix eventdev queues
---
 drivers/event/dpaa2/dpaa2_eventdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Jerin Jacob July 21, 2020, 5:51 p.m. UTC | #1
On Mon, Jul 13, 2020 at 5:14 PM Apeksha Gupta <apeksha.gupta@nxp.com> wrote:
>
> Event device capability flag added in event driver,
> Event device is capable of enqueuing events of any type to any queue.

Please change the subject to "event/dpaa2: add all type queue capability flag"

Update git commit comment to below or something similar.

dppa2 eventdev device is capable of all type queue feature.
Fix the capability flag to reflect the same.

>
> Fixes: 8f4a294c23 ("event/dpaa2: apply new capability flags")
> Cc: stable@dpdk.org

@Nipun Gupta  @Hemant Agrawal

Please ack the patch.

>
> Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
> ---
> v3:
> * Added patch
> 1. event/dpaa2: Add all type queue capability flag
>
> v2:
> * Removed unrequired patches
> 1. app/test-eventdev: Enhancing perf-queue packet flow
> 2. app/test-eventdev: Removed unwanted checks
> 3. event/dpaa2: Add all type queue capability flag
> 4. app/test-eventdev: Enhancing perf-atq packet flow
> 5. app/test-eventdev: fix eventdev queues
> ---
>  drivers/event/dpaa2/dpaa2_eventdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
> index 0072db153b..14dcc50d4a 100644
> --- a/drivers/event/dpaa2/dpaa2_eventdev.c
> +++ b/drivers/event/dpaa2/dpaa2_eventdev.c
> @@ -407,7 +407,8 @@ dpaa2_eventdev_info_get(struct rte_eventdev *dev,
>                 RTE_EVENT_DEV_CAP_BURST_MODE|
>                 RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
>                 RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
> -               RTE_EVENT_DEV_CAP_NONSEQ_MODE;
> +               RTE_EVENT_DEV_CAP_NONSEQ_MODE |
> +               RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES;
>
>  }
>
> --
> 2.17.1
>
  
Nipun Gupta July 23, 2020, 1:36 p.m. UTC | #2
Acked-by: Nipun Gupta <nipun.gupta@nxp.com>

> -----Original Message-----
> From: Apeksha Gupta <apeksha.gupta@nxp.com>
> Sent: Monday, July 13, 2020 5:14 PM
> To: jerin.jacob@caviumnetworks.com
> Cc: thomas@monjalon.net; dev@dpdk.org; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Nipun Gupta <nipun.gupta@nxp.com>; Apeksha
> Gupta <apeksha.gupta@nxp.com>; stable@dpdk.org
> Subject: [PATCH v3 2/2] event/dpaa2: Add all type queue capability flag
> 
> Event device capability flag added in event driver,
> Event device is capable of enqueuing events of any type to any queue.
> 
> Fixes: 8f4a294c23 ("event/dpaa2: apply new capability flags")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
> ---
> v3:
> * Added patch
> 1. event/dpaa2: Add all type queue capability flag
> 
> v2:
> * Removed unrequired patches
> 1. app/test-eventdev: Enhancing perf-queue packet flow
> 2. app/test-eventdev: Removed unwanted checks
> 3. event/dpaa2: Add all type queue capability flag
> 4. app/test-eventdev: Enhancing perf-atq packet flow
> 5. app/test-eventdev: fix eventdev queues
> ---
>  drivers/event/dpaa2/dpaa2_eventdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c
> b/drivers/event/dpaa2/dpaa2_eventdev.c
> index 0072db153b..14dcc50d4a 100644
> --- a/drivers/event/dpaa2/dpaa2_eventdev.c
> +++ b/drivers/event/dpaa2/dpaa2_eventdev.c
> @@ -407,7 +407,8 @@ dpaa2_eventdev_info_get(struct rte_eventdev *dev,
>  		RTE_EVENT_DEV_CAP_BURST_MODE|
>  		RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
>  		RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
> -		RTE_EVENT_DEV_CAP_NONSEQ_MODE;
> +		RTE_EVENT_DEV_CAP_NONSEQ_MODE |
> +		RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES;
> 
>  }
> 
> --
> 2.17.1
  
Jerin Jacob July 24, 2020, 5:24 a.m. UTC | #3
On Thu, Jul 23, 2020 at 7:06 PM Nipun Gupta <nipun.gupta@nxp.com> wrote:
>
> Acked-by: Nipun Gupta <nipun.gupta@nxp.com>
>
> > -----Original Message-----
> > From: Apeksha Gupta <apeksha.gupta@nxp.com>
> > Sent: Monday, July 13, 2020 5:14 PM
> > To: jerin.jacob@caviumnetworks.com
> > Cc: thomas@monjalon.net; dev@dpdk.org; Hemant Agrawal
> > <hemant.agrawal@nxp.com>; Nipun Gupta <nipun.gupta@nxp.com>; Apeksha
> > Gupta <apeksha.gupta@nxp.com>; stable@dpdk.org
> > Subject: [PATCH v3 2/2] event/dpaa2: Add all type queue capability flag
> >
> > Event device capability flag added in event driver,
> > Event device is capable of enqueuing events of any type to any queue.
> >
> > Fixes: 8f4a294c23 ("event/dpaa2: apply new capability flags")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>


Series applied to dpdk-next-eventdev/master. Thanks.


> > ---
> > v3:
> > * Added patch
> > 1. event/dpaa2: Add all type queue capability flag
> >
> > v2:
> > * Removed unrequired patches
> > 1. app/test-eventdev: Enhancing perf-queue packet flow
> > 2. app/test-eventdev: Removed unwanted checks
> > 3. event/dpaa2: Add all type queue capability flag
> > 4. app/test-eventdev: Enhancing perf-atq packet flow
> > 5. app/test-eventdev: fix eventdev queues
> > ---
> >  drivers/event/dpaa2/dpaa2_eventdev.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c
> > b/drivers/event/dpaa2/dpaa2_eventdev.c
> > index 0072db153b..14dcc50d4a 100644
> > --- a/drivers/event/dpaa2/dpaa2_eventdev.c
> > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c
> > @@ -407,7 +407,8 @@ dpaa2_eventdev_info_get(struct rte_eventdev *dev,
> >               RTE_EVENT_DEV_CAP_BURST_MODE|
> >               RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
> >               RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
> > -             RTE_EVENT_DEV_CAP_NONSEQ_MODE;
> > +             RTE_EVENT_DEV_CAP_NONSEQ_MODE |
> > +             RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES;
> >
> >  }
> >
> > --
> > 2.17.1
>
  

Patch

diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
index 0072db153b..14dcc50d4a 100644
--- a/drivers/event/dpaa2/dpaa2_eventdev.c
+++ b/drivers/event/dpaa2/dpaa2_eventdev.c
@@ -407,7 +407,8 @@  dpaa2_eventdev_info_get(struct rte_eventdev *dev,
 		RTE_EVENT_DEV_CAP_BURST_MODE|
 		RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
 		RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
-		RTE_EVENT_DEV_CAP_NONSEQ_MODE;
+		RTE_EVENT_DEV_CAP_NONSEQ_MODE |
+		RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES;
 
 }