From patchwork Thu Jul 9 06:26:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simei Su X-Patchwork-Id: 73579 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 725F5A0526; Thu, 9 Jul 2020 08:27:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 590B61DAD8; Thu, 9 Jul 2020 08:27:56 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E66551DA96 for ; Thu, 9 Jul 2020 08:27:54 +0200 (CEST) IronPort-SDR: WvM8y8VOI7TxvBiXUZSedXwaT5UGFSafn+bQLWwRlWDN0ZuGFNaqjOeRs4Ub3xyhQrT/8THOMs 8qOONhDzmogA== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="209474124" X-IronPort-AV: E=Sophos;i="5.75,330,1589266800"; d="scan'208";a="209474124" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 23:27:53 -0700 IronPort-SDR: AfkzAoCSA1VfwjWajGw6D33CpOSDbBCtJzNf1R+Ip2ysMFdGmbezi4DUcLzfAEtoK2dXHwHFG9 BqSWhH+cUbqw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,330,1589266800"; d="scan'208";a="268675988" Received: from unknown (HELO npg-dpdk-cvl-simeisu-118d193.sh.intel.com) ([10.67.110.178]) by fmsmga008.fm.intel.com with ESMTP; 08 Jul 2020 23:27:52 -0700 From: Simei Su To: qi.z.zhang@intel.com Cc: dev@dpdk.org, jia.guo@intel.com, Simei Su Date: Thu, 9 Jul 2020 14:26:34 +0800 Message-Id: <1594275994-318254-1-git-send-email-simei.su@intel.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH] net/ice: fix invalid RSS type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When a RSS rule with only RSS type modifirer L2/L3/L4 SRC/DST_ONLY, it should return failure. This patch adds invalid RSS type check. Fixes: dfaedcf20170 ("net/ice: refactor PF hash flow") Signed-off-by: Simei Su --- drivers/net/ice/ice_hash.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index cbd6116..777bd6d 100644 --- a/drivers/net/ice/ice_hash.c +++ b/drivers/net/ice/ice_hash.c @@ -721,6 +721,11 @@ struct ice_hash_match_type ice_hash_type_list[] = { * of the same level. */ rss_type = rte_eth_rss_hf_refine(rss_type); + /* Check if only L2/L3/L4 src/dst-only exists. */ + if ((rss_type & 0xffffffff) == 0) + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_ACTION, action, + "rss type with only L2/L3/L4 src/dst only is invalid"); combine_type = ETH_RSS_L2_SRC_ONLY | ETH_RSS_L2_DST_ONLY |