[v2] build: replace meson OS detection with variable
Checks
Commit Message
Some places were calling the meson function host_machine.system()
instead of the variables is_windows and is_linux defined
in config/meson.build.
At the same time, the missing "Linux restriction" reason is added to
pfe and octeontx2 crypto PMDs.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: add missing reason to drivers
---
buildtools/pmdinfogen/meson.build | 2 +-
drivers/crypto/octeontx2/meson.build | 5 +++--
drivers/net/pfe/meson.build | 3 ++-
examples/ntb/meson.build | 2 +-
4 files changed, 7 insertions(+), 5 deletions(-)
Comments
On Tue, Jun 30, 2020 at 03:15:22PM +0200, Thomas Monjalon wrote:
> Some places were calling the meson function host_machine.system()
> instead of the variables is_windows and is_linux defined
> in config/meson.build.
>
> At the same time, the missing "Linux restriction" reason is added to
> pfe and octeontx2 crypto PMDs.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2: add missing reason to drivers
> ---
Thanks LGTM.
> Some places were calling the meson function host_machine.system()
> instead of the variables is_windows and is_linux defined
> in config/meson.build.
>
> At the same time, the missing "Linux restriction" reason is added to
> pfe and octeontx2 crypto PMDs.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
30/06/2020 15:28, Akhil Goyal:
> > Some places were calling the meson function host_machine.system()
> > instead of the variables is_windows and is_linux defined
> > in config/meson.build.
> >
> > At the same time, the missing "Linux restriction" reason is added to
> > pfe and octeontx2 crypto PMDs.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied
> Some places were calling the meson function host_machine.system() instead of
> the variables is_windows and is_linux defined in config/meson.build.
>
> At the same time, the missing "Linux restriction" reason is added to pfe and
> octeontx2 crypto PMDs.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
-if host_machine.system() == 'windows'
+if is_windows
subdir_done()
endif
@@ -1,8 +1,9 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright (C) 2019 Marvell International Ltd.
-if host_machine.system() != 'linux'
- build = false
+if not is_linux
+ build = false
+ reason = 'only supported on Linux'
endif
deps += ['bus_pci']
@@ -1,8 +1,9 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright 2019 NXP
-if host_machine.system() != 'linux'
+if not is_linux
build = false
+ reason = 'only supported on Linux'
endif
deps += ['common_dpaax']
@@ -7,7 +7,7 @@
# DPDK instance, use 'make'
allow_experimental_apis = true
-if host_machine.system() != 'linux'
+if not is_linux
build = false
endif
deps += 'rawdev'