[v3,03/10] check_maintainers: change variable names
Checks
Commit Message
Use blocklist where blacklist was used and allowlist
where whitelist was used.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Luca Boccassi <bluca@debian.org>
---
devtools/check-maintainers.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Comments
13/06/2020 02:00, Stephen Hemminger:
> Use blocklist where blacklist was used and allowlist
> where whitelist was used.
This is a mechanical, not accurate, replacement.
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Luca Boccassi <bluca@debian.org>
> ---
> --- a/devtools/check-maintainers.sh
> +++ b/devtools/check-maintainers.sh
> # empty line delimit end of section
> - whitelist=$(files $flines)
> - blacklist=$(files $xlines)
> - match=$(aminusb "$whitelist" "$blacklist")
> - if [ -n "$whitelist" ] ; then
> + allowlist=$(files $flines)
> + blocklist=$(files $xlines)
> + match=$(aminusb "$allowlist" "$blocklist")
> + if [ -n "$allowlist" ] ; then
> printf "# $title "
It is listing files with exclusions.
The concept allow/block does not match here.
I would prefer "files" and "xfiles" as variable names.
@@ -42,10 +42,10 @@ parse_fx () # <index file>
for line in $( (sed '/^-\+$/d' $1 ; echo) | sed 's,^$,§,') ; do
if echo "$line" | grep -q '^§$' ; then
# empty line delimit end of section
- whitelist=$(files $flines)
- blacklist=$(files $xlines)
- match=$(aminusb "$whitelist" "$blacklist")
- if [ -n "$whitelist" ] ; then
+ allowlist=$(files $flines)
+ blocklist=$(files $xlines)
+ match=$(aminusb "$allowlist" "$blocklist")
+ if [ -n "$allowlist" ] ; then
printf "# $title "
maintainers=$(echo "$maintainers" | sed -r 's,.*<(.*)>.*,\1,')
maintainers=$(printf "$maintainers" | sed -e 's,^,<,' -e 's,$,>,')