[dpdk-dev] hash: fix broken compatability with 2.0

Message ID 1442963537-9795-1-git-send-email-stephen@networkplumber.org
State Rejected, archived
Headers show

Commit Message

Stephen Hemminger Sept. 22, 2015, 11:12 p.m.
Version 2.1 must retain source code compatability with 2.0,
all structure fields should be retained. If a field is no
longer used it should have been marked as deprecated.

Fixes: 661e75ef8cac ("hash: rename unused field")

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_hash/rte_hash.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Thomas Monjalon Oct. 21, 2015, 1:48 p.m. | #1
2015-09-22 16:12, Stephen Hemminger:
> Version 2.1 must retain source code compatability with 2.0,
> all structure fields should be retained. If a field is no
> longer used it should have been marked as deprecated.
> 
> Fixes: 661e75ef8cac ("hash: rename unused field")
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

This rollback would be only useful for a 2.1 release.

Patch

diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h
index 175c0bb..47d6e4d 100644
--- a/lib/librte_hash/rte_hash.h
+++ b/lib/librte_hash/rte_hash.h
@@ -69,7 +69,8 @@  typedef uint32_t (*rte_hash_function)(const void *key, uint32_t key_len,
 struct rte_hash_parameters {
 	const char *name;		/**< Name of the hash. */
 	uint32_t entries;		/**< Total hash table entries. */
-	uint32_t reserved;		/**< Unused field. Should be set to 0 */
+	uint32_t num_buckets		/**< Unused in current algorithm */
+		__attribute__((deprecated));
 	uint32_t key_len;		/**< Length of hash key. */
 	rte_hash_function hash_func;	/**< Primary Hash function used to calculate hash. */
 	uint32_t hash_func_init_val;	/**< Init value used by hash_func. */