compress/qat: revert change in GEN3 marketing name
diff mbox series

Message ID 20200608144133.4237-1-adamx.dybkowski@intel.com
State Superseded
Delegated to: akhil goyal
Headers show
Series
  • compress/qat: revert change in GEN3 marketing name
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing success Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS

Commit Message

Adam Dybkowski June 8, 2020, 2:41 p.m. UTC
This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 doc/guides/cryptodevs/qat.rst       | 6 +++---
 drivers/compress/qat/qat_comp_pmd.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Trahe, Fiona June 24, 2020, 2:46 p.m. UTC | #1
> -----Original Message-----
> From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Sent: Monday, June 8, 2020 3:42 PM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH] compress/qat: revert change in GEN3 marketing name
> 
> This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Akhil Goyal June 24, 2020, 2:49 p.m. UTC | #2
Hi Adam/Fiona,

Please mention a reason why this patch need to be reverted.
We cannot keep on changing a marketing name in every release.
If this patch is needed, then we should also queue it for stable backporting.

Regards,
Akhil
> > -----Original Message-----
> > From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > Sent: Monday, June 8, 2020 3:42 PM
> > To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>;
> akhil.goyal@nxp.com
> > Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > Subject: [PATCH] compress/qat: revert change in GEN3 marketing name
> >
> > This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Adam Dybkowski June 24, 2020, 2:52 p.m. UTC | #3
Akhil,

This doesn't have to be backported as the original patch was withdrawn from the stable before the release, thanks to Fiona's prompt action. That's why this commit revert patch affects only the dev branch.

Adam 

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Wednesday, 24 June, 2020 16:50
> To: Trahe, Fiona <fiona.trahe@intel.com>; Dybkowski, AdamX
> <adamx.dybkowski@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH] compress/qat: revert change in GEN3 marketing name
> 
> Hi Adam/Fiona,
> 
> Please mention a reason why this patch need to be reverted.
> We cannot keep on changing a marketing name in every release.
> If this patch is needed, then we should also queue it for stable backporting.
> 
> Regards,
> Akhil
> > > -----Original Message-----
> > > From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > > Sent: Monday, June 8, 2020 3:42 PM
> > > To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>;
> > akhil.goyal@nxp.com
> > > Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > > Subject: [PATCH] compress/qat: revert change in GEN3 marketing name
> > >
> > > This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.
> > >
> > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Akhil Goyal June 24, 2020, 2:55 p.m. UTC | #4
> 
> Akhil,
> 
> This doesn't have to be backported as the original patch was withdrawn from
> the stable before the release, thanks to Fiona's prompt action. That's why this
> commit revert patch affects only the dev branch.
> 

Ok send a v2 with proper description why this need to be reverted.
Trahe, Fiona June 24, 2020, 3:23 p.m. UTC | #5
Hi Akhil,

Sorry about the confusion.
This was a simple internal miscommunication - there was a decision made to change the name, so we did promptly.
The decision was reversed pretty soon after due to an impact on other projects, but I was out-of-the loop on it - I just discovered it recently. 

Do you still need a v2? I'm not sure how much of that is worth putting in a commit message.

Fiona

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Wednesday, June 24, 2020 3:55 PM
> To: Dybkowski, AdamX <adamx.dybkowski@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>;
> dev@dpdk.org
> Subject: RE: [PATCH] compress/qat: revert change in GEN3 marketing name
> 
> 
> >
> > Akhil,
> >
> > This doesn't have to be backported as the original patch was withdrawn from
> > the stable before the release, thanks to Fiona's prompt action. That's why this
> > commit revert patch affects only the dev branch.
> >
> 
> Ok send a v2 with proper description why this need to be reverted.
Akhil Goyal July 1, 2020, 8:01 p.m. UTC | #6
Hi Fiona,
> 
> Hi Akhil,
> 
> Sorry about the confusion.
> This was a simple internal miscommunication - there was a decision made to
> change the name, so we did promptly.
> The decision was reversed pretty soon after due to an impact on other projects,
> but I was out-of-the loop on it - I just discovered it recently.
> 
> Do you still need a v2? I'm not sure how much of that is worth putting in a
> commit message.
> 
We should not leave the description blank.
Probably it can be written that the marketing name was reverted back as it was
Impacting other projects.
Or something of that sort.

Regards,
Akhil

Patch
diff mbox series

diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index c2cc3d5ca..808a5f504 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -23,7 +23,7 @@  poll mode crypto driver support for the following hardware accelerator devices:
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
 * ``Intel QuickAssist Technology D15xx``
-* ``Intel QuickAssist Technology P5xxx``
+* ``Intel QuickAssist Technology C4xxx``
 
 
 Features
@@ -155,7 +155,7 @@  poll mode crypto driver support for the following hardware accelerator devices:
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
 * ``Intel QuickAssist Technology D15xx``
-* ``Intel QuickAssist Technology P5xxx``
+* ``Intel QuickAssist Technology C4xxx``
 
 The QAT ASYM PMD has support for:
 
@@ -385,7 +385,7 @@  to see the full table)
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | No  | No  | 2   | D15xx    | p             | qat_d15xx     | d15xx      | 6f54   | 1    | 6f55   | 16     |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
-   | Yes | No  | No  | 3   | P5xxx    | p             | qat_p5xxx     | p5xxx      | 18a0   | 1    | 18a1   | 128    |
+   | Yes | No  | No  | 3   | C4xxx    | p             | qat_c4xxx     | c4xxx      | 18a0   | 1    | 18a1   | 128    |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
 
 * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with 01.org driver version 4.9.0+
diff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c
index fe62de533..e2b5f8ce3 100644
--- a/drivers/compress/qat/qat_comp_pmd.c
+++ b/drivers/compress/qat/qat_comp_pmd.c
@@ -656,7 +656,7 @@  qat_comp_dev_create(struct qat_pci_device *qat_pci_dev,
 {
 	int i = 0;
 	if (qat_pci_dev->qat_dev_gen == QAT_GEN3) {
-		QAT_LOG(ERR, "Compression PMD not supported on QAT P5xxx");
+		QAT_LOG(ERR, "Compression PMD not supported on QAT c4xxx");
 		return 0;
 	}