lib/librte_net: fix bug for ipv4 checksum calculating
diff mbox series

Message ID 20200526100805.24896-1-guohongzhi1@huawei.com
State Accepted
Delegated to: Thomas Monjalon
Headers show
Series
  • lib/librte_net: fix bug for ipv4 checksum calculating
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/iol-testing warning Testing issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/checkpatch warning coding style issues

Commit Message

Hongzhi Guo May 26, 2020, 10:08 a.m. UTC
From: Hongzhi Guo <guohongzhi1@huawei.com>

0xffff is invalid for IPv4 checksum(RFC1624)

Fixes: 6006818cfb26 ("net: new checksum functions")
Cc: stable@dpdk.org

Reviewed-By: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>

Signed-off-by: Hongzhi Guo <guohongzhi1@huawei.com>
---
 lib/librte_net/rte_ip.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon June 24, 2020, 11:53 a.m. UTC | #1
26/05/2020 12:08, guohongzhi:
> From: Hongzhi Guo <guohongzhi1@huawei.com>
> 
> 0xffff is invalid for IPv4 checksum(RFC1624)
> 
> Fixes: 6006818cfb26 ("net: new checksum functions")
> Cc: stable@dpdk.org
> 
> Reviewed-By: Morten Brørup <mb@smartsharesystems.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Signed-off-by: Hongzhi Guo <guohongzhi1@huawei.com>

The Signed-off should be in chronological order, before reviews.

As suggested in previous patch, the title should be
	net: fix IPv4 checksum

I am doing above modifications while merging.

More advices about submitting patches:
	- use -v2, -v3, etc when sending new versions
	- add a changelog below the line ---
	- use --in-reply-to to keep all versions threaded


> @@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
>  {
>  	uint16_t cksum;
>  	cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
> -	return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
> +	return (uint16_t)~cksum;
>  }

Applied, thanks

Patch
diff mbox series

diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 1ceb7b7..ece2e43 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -267,7 +267,7 @@  rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
 {
 	uint16_t cksum;
 	cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
-	return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
+	return (uint16_t)~cksum;
 }
 
 /**