From patchwork Tue May 19 05:08:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Harris, Cody" X-Patchwork-Id: 70412 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CE6DA0093; Tue, 19 May 2020 07:08:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10DE11D427; Tue, 19 May 2020 07:08:25 +0200 (CEST) Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by dpdk.org (Postfix) with ESMTP id 730641D421 for ; Tue, 19 May 2020 07:08:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1589864904; x=1621400904; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ahWZ5P+JtUsaqYhpymIw4Pz6W/mfXni1SS9bRnjIQuY=; b=b+As9BWJfSkEIMnxO5JOz4wapdF6gY2dun7DYERU4WP+2AsoqtUzZLQY BW9Yd9iN4LEWj6hcQPkoKl5sbW4sE/841Jf+ONyM5E9RfV37a3fhxZfsK 2qn6cJGfDpxC6J7C3FwlT+RUElUs6rmtxjtNFer4aguP6Kw7xogi6IxPX Q=; IronPort-SDR: t3VzYJSZJD09Zm9mvmF7C25fas1LeTTOcdPY4fj5R3wnF0N4bg/CLgLdc2zwH1/RvR3fzAUegF Lx9JcJeZFC0A== X-IronPort-AV: E=Sophos;i="5.73,409,1583193600"; d="scan'208";a="31072050" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-1e-303d0b0e.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP; 19 May 2020 05:08:11 +0000 Received: from EX13MTAUWA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1e-303d0b0e.us-east-1.amazon.com (Postfix) with ESMTPS id E3820A2466 for ; Tue, 19 May 2020 05:08:10 +0000 (UTC) Received: from EX13D21UWA003.ant.amazon.com (10.43.160.184) by EX13MTAUWA001.ant.amazon.com (10.43.160.58) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 19 May 2020 05:08:10 +0000 Received: from EX13MTAUEA002.ant.amazon.com (10.43.61.77) by EX13D21UWA003.ant.amazon.com (10.43.160.184) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 19 May 2020 05:08:10 +0000 Received: from dev-dsk-codh-2a-206409ba.us-west-2.amazon.com (172.19.57.163) by mail-relay.amazon.com (10.43.61.169) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 19 May 2020 05:08:09 +0000 Received: by dev-dsk-codh-2a-206409ba.us-west-2.amazon.com (Postfix, from userid 9465375) id DAA1942298; Tue, 19 May 2020 05:08:08 +0000 (UTC) From: Cody Harris To: CC: Cody Harris Date: Tue, 19 May 2020 05:08:07 +0000 Message-ID: <20200519050807.21730-1-codh@amazon.com> X-Mailer: git-send-email 2.24.1.AMZN In-Reply-To: References: MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3] net/ixgbe: include QPRDC in imissed stat X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The ixgbe imissed statstic originally only contained dropped packets counted by the RXMPC registers. This change includes additional types of packet drops counted by the QPRDC registers. Intel support confimed that the packet drops counted by the QPRDC registers do not double-count drops counted by RXMPC registers: "RXMPC counts packets that are dropped because there is no room in the internal packet buffer. QPRDC counts packets that are dropped because they can't be transferred to system memory. These packets have been stored in the internal packet buffer, so there should be no overlap with RXMPC." Signed-off-by: Cody Harris --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index a4e5c539d..7284ca28e 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -3366,7 +3366,7 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) } /* Rx Errors */ - stats->imissed = total_missed_rx; + stats->imissed = total_missed_rx + total_qprdc; stats->ierrors = hw_stats->crcerrs + hw_stats->mspdc + hw_stats->rlec +