From patchwork Mon May 18 10:39:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sexton, Rory" X-Patchwork-Id: 70377 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24371A0093; Mon, 18 May 2020 13:00:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 378BF1D506; Mon, 18 May 2020 13:00:05 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 296131D44E for ; Mon, 18 May 2020 13:00:02 +0200 (CEST) IronPort-SDR: hvjAvAjH8nfq3obXhbQwIYZyxZrfJ3XHoF+IWCiPOkDhuCcm41V9CUTCFLQqukuT3PCi3WU+lq KMIxg9RTFXNg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 04:00:02 -0700 IronPort-SDR: m1qX0M4pyx83E5sQuGWTQfGLu39+yQudSTv7H7WO5dU+r/a0Dxbf3YcV29gzQzA6IBC1pb61ja 2rhhv4xmVkuw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,407,1583222400"; d="scan'208";a="439173073" Received: from silpixa00399913.ir.intel.com (HELO silpixa00399913.ger.corp.intel.com) ([10.237.222.230]) by orsmga005.jf.intel.com with ESMTP; 18 May 2020 04:00:01 -0700 From: "Sexton, Rory" To: dev@dpdk.org, david.hunt@intel.com Cc: "Sexton, Rory" Date: Mon, 18 May 2020 11:39:01 +0100 Message-Id: <20200518103902.27927-2-rory.sexton@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200518103902.27927-1-rory.sexton@intel.com> References: <20200518103902.27927-1-rory.sexton@intel.com> Subject: [dpdk-dev] [PATCH v2 2/3] examples/vm_power_manager: Allowing power managing of idle cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This change is required to allow the branch ratio algorithm to power manage cores with no workload running on them. This is useful both when idle cores don't use C-states and for a number of hyperthreading scenarios. Signed-off-by: Rory Sexton Reviewed-by: David Hunt --- examples/vm_power_manager/oob_monitor_x86.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/vm_power_manager/oob_monitor_x86.c b/examples/vm_power_manager/oob_monitor_x86.c index 3c514475f..a5b1c168c 100644 --- a/examples/vm_power_manager/oob_monitor_x86.c +++ b/examples/vm_power_manager/oob_monitor_x86.c @@ -96,12 +96,12 @@ apply_policy(int core) g_branch_misses = miss_diff; if (hits_diff < (INTERVAL*100)) { - /* Likely no workload running on this core. Skip. */ - return -1.0; + /* Likely no workload running on this core. */ + ratio = 0.0; + } else { + ratio = (float)miss_diff * (float)100 / (float)hits_diff; } - ratio = (float)miss_diff * (float)100 / (float)hits_diff; - /* * Store the last few directions that the ratio indicates * we should take. If there's on 'up', then we scale up