From patchwork Fri May 1 13:53:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 69643 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 857C2A04AE; Fri, 1 May 2020 15:59:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B68631DA62; Fri, 1 May 2020 15:59:31 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CC1A91DA5C for ; Fri, 1 May 2020 15:59:29 +0200 (CEST) IronPort-SDR: qZWsegL7gJofE1XeuM1Oxe3tiLD2Z28k2iWyuDf7zW4y/A47pcFUvxosmVDKdwBmfmyAiGdCKP HFYRkETxlxMg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2020 06:59:29 -0700 IronPort-SDR: +DIg2qiXgrDy06i52bFlhT+91F/o/gIu/7g5qz1k8UOOUai4dkyvUA6f7jZRLlQrHymj2Zb96Z PklgWnfrEc4Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,339,1583222400"; d="scan'208";a="433318856" Received: from silpixa00399126.ir.intel.com ([10.237.222.218]) by orsmga005.jf.intel.com with ESMTP; 01 May 2020 06:59:28 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: thomas@monjalon.net, bluca@debian.org, david.marchand@redhat.com, ktraynor@redhat.com, Bruce Richardson Date: Fri, 1 May 2020 14:53:56 +0100 Message-Id: <20200501135401.28124-3-bruce.richardson@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200501135401.28124-1-bruce.richardson@intel.com> References: <20200429100831.398-1-bruce.richardson@intel.com> <20200501135401.28124-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 2/7] build: remove unnecessary variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since all libraries are explicitly linked as part of a build, we no longer need to track ones that should be always included for linking against apps. Previously telemetry was special-cased for linking as it was not directly needed by the linker when linking the apps, since they never called into it directly. This meant that it could be forgotten when specifying the app dependencies, and so the telemetry support would not work. This special-casing was never needed for make as it always linked in all libraries, as meson does now. Signed-off-by: Bruce Richardson --- V2: added more detail on the history to the commit log --- app/meson.build | 2 +- lib/librte_telemetry/meson.build | 1 - meson.build | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/app/meson.build b/app/meson.build index 0f7fe9464..25f2da82e 100644 --- a/app/meson.build +++ b/app/meson.build @@ -36,7 +36,7 @@ foreach app:apps # use "deps" for internal DPDK dependencies, and "ext_deps" for # external package/library requirements ext_deps = [] - deps = dpdk_app_link_libraries + deps = [] subdir(name) diff --git a/lib/librte_telemetry/meson.build b/lib/librte_telemetry/meson.build index 1bdf128c1..c6e8cc5de 100644 --- a/lib/librte_telemetry/meson.build +++ b/lib/librte_telemetry/meson.build @@ -8,7 +8,6 @@ deps += ['metrics', 'ethdev'] jansson = dependency('jansson', required: false) if jansson.found() ext_deps += jansson - dpdk_app_link_libraries += ['telemetry'] else build = false reason = 'missing dependency "jansson"' diff --git a/meson.build b/meson.build index d36580438..d8504afbf 100644 --- a/meson.build +++ b/meson.build @@ -19,7 +19,6 @@ dpdk_static_libraries = [] dpdk_driver_classes = [] dpdk_drivers = [] dpdk_extra_ldflags = [] -dpdk_app_link_libraries = [] dpdk_libs_disabled = [] dpdk_drvs_disabled = [] abi_version_file = files('ABI_VERSION')