From patchwork Tue Apr 21 07:42:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kiran KN X-Patchwork-Id: 68990 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F28F8A0561; Tue, 21 Apr 2020 09:42:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2B981C296; Tue, 21 Apr 2020 09:42:32 +0200 (CEST) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) by dpdk.org (Postfix) with ESMTP id 5FE521C221 for ; Tue, 21 Apr 2020 09:42:31 +0200 (CEST) Received: from pps.filterd (m0108163.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03L7g6Ca001039; Tue, 21 Apr 2020 00:42:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : content-type : content-id : content-transfer-encoding : mime-version; s=PPS1017; bh=cv94dbxnkDBc6vDB6FUDgUmcVk51gP9/HzCiGNsUC3w=; b=Q3T90GF/yDT35ih0ubDIfF96ST8WWdt2g6BbLOwDSiyZk7XKH7kpynCQqQfkYMlnn9C8 OtpPAJW5VliG0eS6mDvdH5tbpIhR4x35HOW5kdw7AHz/ai5GhqMgvPYNedrMboDbLi24 w+uML9bXfrg7rg6jMHPy1gTibHfRl0DOnHLbY01M7631LlyUwbdNQ45Bj8wsQ7r9z7wL htJdghntEmW79O0Zj9ArTf7db2IHaavzfKniUUp6uei3nE69CspKEErUfRbEFOLBICp4 lbqW9P+GYMNJmwRY1Hv4Z3dl9YkxjM9CP4q5MPfL2ci+rh3sAERngmav66U7Z6sL138w qw== Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by mx0b-00273201.pphosted.com with ESMTP id 30fvsscewm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Apr 2020 00:42:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iiVqglfxdJ7rBih3zUb8vKSfVulWH0+FY2vdscqfWUix2aXRFCkBGjjud+cjc+sQ+fmPw5E8+z/LZXkwDKrRZraPlrPyTskhi3KMOuwiDwtfNHfh38HRPriTEz/ftY0WcCqKz/UX0sPb17/C6tU565SwFWBSZ1OaZWK/bQe+vq1EHh1ipErmqiASluh1jAGQnPa6SSAjR9wK4tJpWRMvxbRKmaAL0Q3lfHORRui+ZAD8p4AQc8FCAGgqJR2eYBzM30ibtKRZGHkft2UiuSoAHLETJYn98vz4yNIwY1vugNukiXQ7uNay1wcSaMXXyzyWR+omRIdlSzty08gRayxdfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cv94dbxnkDBc6vDB6FUDgUmcVk51gP9/HzCiGNsUC3w=; b=cWgJQ1W4aSNTYv6dUR+hlfj/MvXJokhdEtqJMfoZLNNhSSmu5Ah9aErzErmi8KYg++OVX4mE2pRz5qT6ID5ESQ9dnV4uUwIV36JGaz7C0kasWmbjrIjtqV325vUP2lHiCJ/LD0aclbJl4pxYxDBYJT51V6B1sFz4hdBGb15rCJUTsT5JCVgSeqf1qw70CeItHoFXX1QILa4OognbPR6kWNVgx27rzBJrDwZ5KWO+cQ4kKnFkc0ZPK2axP01Wi2luRYgofgBHVbbItru8HrfyNofLZSzJAgdyV+XmrKDgpfI6cKiOZphcAZV8XbrKP1vMuTy0xx67wIU2fgdSk5oi9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cv94dbxnkDBc6vDB6FUDgUmcVk51gP9/HzCiGNsUC3w=; b=FH1yd6j4U4ln8mhf96WD83QKvNpEd+fBHPmq/VJNZrit7XCGOXlY85ems10WmPCsOzraeVtZodn+XwnQTULsABy0QsPWLrcQz1AzctLIZ8WUhDHN+0e766LDCuazHhYklxosgekavICLu/asF5VjGSUNgQLBylv0s5yyYRYvctM= Received: from MWHPR0501MB3755.namprd05.prod.outlook.com (2603:10b6:301:7d::23) by MWHPR0501MB3916.namprd05.prod.outlook.com (2603:10b6:301:7b::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.6; Tue, 21 Apr 2020 07:42:28 +0000 Received: from MWHPR0501MB3755.namprd05.prod.outlook.com ([fe80::991b:9002:99f4:9675]) by MWHPR0501MB3755.namprd05.prod.outlook.com ([fe80::991b:9002:99f4:9675%6]) with mapi id 15.20.2921.027; Tue, 21 Apr 2020 07:42:28 +0000 From: Kiran KN To: "dev@dpdk.org" CC: Thomas Monjalon , "david.marchand@redhat.com" Thread-Topic: [PATCH] eal: changes for setting control thread mask Thread-Index: AQHWF7Bo40CUKLJZD0GYOQMe2pH7cQ== Date: Tue, 21 Apr 2020 07:42:28 +0000 Message-ID: <1BA38E99-C6F7-4A17-B6CA-D1D06F707590@juniper.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Enabled=true; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Name=Juniper Business Use Only; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Enabled=true; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_ContentBits=0; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_Method=Standard; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_ActionId=5a108ebc-af15-48e5-bcf0-0000619da019; MSIP_Label_9784d817-3396-4a4f-b60c-3ef6b345fe55_SetDate=2020-04-21T07:36:43Z; user-agent: Microsoft-MacOutlook/10.1e.0.191013 x-originating-ip: [2406:7400:73:db35:45ac:d5d3:3f82:77af] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 68d77b6a-11c9-4809-f5c5-08d7e5c78ad0 x-ms-traffictypediagnostic: MWHPR0501MB3916: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1775; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR0501MB3755.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(346002)(376002)(39860400002)(136003)(366004)(316002)(33656002)(2906002)(81156014)(8676002)(478600001)(8936002)(6506007)(186003)(86362001)(5660300002)(2616005)(91956017)(4326008)(54906003)(71200400001)(6916009)(66446008)(64756008)(66556008)(66476007)(76116006)(6486002)(6512007)(36756003)(66946007); DIR:OUT; SFP:1102; received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D3WrTzD3JslL0Em/Nr4dc5K3wuIvyCZfYau7RVWiy+cXkTlA+2sb6m1sAYczjISySs5pjm9dzabVyR/JGMnnSoO7TBs+s2iUB2LzG0glO2EZIa/YtLuBhAuKtKy7qHrAINT+UT/MzQxhBacXOPoG847J77quPeqnbgEhOilNfqFZXjhu+HfvAsIx7R/VBxT6I9p86zq46Zoi5r1ZyM/FBpSGR4x5/4LMWFywwLfEWnElcTBwmghX/7//f8eJHWAbItYYqoRWvVdNkejvEUBGi9y5qOHLwKbxLnwkdXDG4mveULZEK5okjQpCWnIlb1hbj7GTKAOCMdvy6nJy/Y7ejL4Dlo1xLTSa6eC9dZCtQJ6Ssj7bAkAt5/83gowgaucar3wY/mqgdYqC/OOM6wEgXyBW8nLWM+REQolHc/TjFJeP08wBQ7g0zeA2ML2L9EMw x-ms-exchange-antispam-messagedata: co+aStiks8cusJSpwAmaEqKIlVJXoRaHLpk6Za7bWZwQZqhykwXKOVrbYTvF1VbdTJnsw3VheD8DA95OBZLa3dsLVhtMLrhKaUfxOXM2lcKG4q8lLSSarcGCG5DoPClKZ0YI+/P0kzVt89PyiHfMT8IV7XCcB+ypNCS2tfZkkwQpFAP3V0H3kjERfED67WWkRmenjF+IBDsN+DwYAFWbculaCwZY3IoqESK53JU8iPQ4Z1duGuG1RrY3aI6Uuzi7PUG43Sv559c32aVQQ6HxBMxXeRqp/KgSUUSZWZ3QYfDSc9dAb4JjTZREawTi+kfcaQQmHHNeaTwtFMip1SRaqGqm8pWUoz3VhZ0Xr+7GezVzaPvU+2TsQTBUz2mGOKlBzbyv9p2GWcTpGYGhrG+8M+OakUiq/N8lV116wkUkXpanrR6k/NJYaOSaMw3F6OJIshRQ+URdBLjnzhUcCwuLwIym21chtF0rTfPpXuhsZ3KxEJvl2LZhovuCDIEe6HbaoVw/tJs/GqN4bksfS/cIrte/jj8er6iPxVSRZSbPxxwW+64z0bhH468hEUB6ERIDtJr8ztUkNNnebXLDmEj8CVIyXX9x1XgcYiVUPeOIg8fQsrbOADs3QoGF71SMeDtDFkjpVqYEWuDByINPibXlri+kJvNUYqijeIxBN7UzartkUOEdm16zNvLUuRzKFgmaS6tup9/wxH67F3vr+bso0MwgKnllXnjgBcbeecffk+P6qW66ZQE9/8Ky9KKZdjFgJfjvgZPcIxhJJH/DenmBeSEzJUT0Em8GHKm8UigkC25gqu3XcGXwciBzDpeQtH0e58IXeYfrVZO7jD1Bq/GW0AK6L+mYmKpkj9HWpFfD9a8= x-ms-exchange-transport-forked: True Content-ID: <003585F76681FB4B94AA65CDCB2080C1@namprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-Network-Message-Id: 68d77b6a-11c9-4809-f5c5-08d7e5c78ad0 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 07:42:28.4848 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x2/CL2ad/gABulT7RMghH2MNPMZILBvDnLEQywlhuK+68hrySL+iz/BKdE9Y7okQYg/FnHkHn5h3UoREtuvDIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0501MB3916 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-21_02:2020-04-20, 2020-04-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 mlxlogscore=999 impostorscore=0 spamscore=0 phishscore=0 adultscore=0 suspectscore=0 clxscore=1011 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004210065 Subject: [dpdk-dev] [PATCH] eal: changes for setting control thread mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Define a global variable ctrl_thread_set which the application can set. If this is the case, use this for setting control thread affinity instead of deducing it from the existing core pinning of the process. signed-off-by: Kiran KN --- lib/librte_eal/common/eal_common_options.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index a7f9c5f9b..1b99a986d 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -41,6 +41,7 @@ eal_short_options[] = "b:" /* pci-blacklist */ "c:" /* coremask */ "s:" /* service coremask */ + "C:" /* control threads */ "d:" /* driver */ "h" /* help */ "l:" /* corelist */ @@ -1201,7 +1202,7 @@ eal_parse_common_option(int opt, const char *optarg, { static int b_used; static int w_used; - + static uint16_t set[RTE_MAX_LCORE]; switch (opt) { /* blacklist */ case 'b': @@ -1295,6 +1296,17 @@ eal_parse_common_option(int opt, const char *optarg, return -1; } break; + /* control threads */ + case 'C': + if (eal_parse_set(optarg, set, RTE_DIM(set)) < 0) { + RTE_LOG(ERR, EAL, "invalid control threads\n"); + return -1; + } + if (convert_to_cpuset(&conf->ctrl_cpuset, set, RTE_DIM(set)) < 0) { + RTE_LOG(ERR, EAL, "Error adding set to control cpuset\n"); + return -1; + } + break; /* service corelist */ case 'S': if (eal_parse_service_corelist(optarg) < 0) { @@ -1542,7 +1554,9 @@ eal_adjust_config(struct internal_config *internal_cfg) lcore_config[cfg->master_lcore].core_role = ROLE_RTE; } - compute_ctrl_threads_cpuset(internal_cfg); + if (CPU_COUNT(&internal_cfg->ctrl_cpuset) == 0) { + compute_ctrl_threads_cpuset(internal_cfg); + } /* if no memory amounts were requested, this will result in 0 and * will be overridden later, right after eal_hugepage_info_init() */ @@ -1656,6 +1670,10 @@ eal_common_usage(void) " '( )' can be omitted for single element group,\n" " '@' can be omitted if cpus and lcores have the same value\n" " -s SERVICE COREMASK Hexadecimal bitmask of cores to be used as service cores\n" + " -C CONTROL THREADS The argument format is\n" + " (list of cpus) or Hexadecimal bitmask of cores\n" + " Within the list of cpus, '-' is used as range seperator,\n" + " ',' is used for single number seperator.\n" " --"OPT_MASTER_LCORE" ID Core ID that is used as master\n" " --"OPT_MBUF_POOL_OPS_NAME" Pool ops name for mbuf to use\n" " -n CHANNELS Number of memory channels\n"